Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peak picking on some spectra takes a very long time #61

Open
lpatiny opened this issue Mar 8, 2017 · 4 comments
Open

Peak picking on some spectra takes a very long time #61

lpatiny opened this issue Mar 8, 2017 · 4 comments
Assignees

Comments

@lpatiny
Copy link
Member

lpatiny commented Mar 8, 2017

Here is an example of jcamp file
test.jdx.zip

The process blocks at the level of
https://github.com/cheminfo/nmr-metadata/blob/17a39cfe2e0efb408a64561170139c87aa1135da/src/index.js#L102

@andcastillo
Copy link
Contributor

andcastillo commented Mar 9, 2017

Yes. There is a problem if you try to optimize too many peaks. Hopefully the Levenberg–Marquardt of Miguel is better than mine and we could optimize much more gaussians in a shorter time. By now, that problems has been solved in the new spectra-data releases by setting optimize to false by default. So, the solution is to update to a higher spectra-data version.

@andcastillo
Copy link
Contributor

@lpatiny @maasencioh

@maasencioh
Copy link
Collaborator

@andcastillo this optimization it's related with this issue?

mljs/levenberg-marquardt#4

@andcastillo
Copy link
Contributor

Not really. What I mean is that I'm using my own LM implementation. It is a transcription from a matlab code. Perhaps yours is better, but now, you need to make some improvements in order I can try to use it here. And the reason of the issue is that my parameters has many orders o magnitud of difference(x is 0.01 ppm range and intensity is 100000000), then, global options for them does not work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants