-
-
Notifications
You must be signed in to change notification settings - Fork 110
feat: allow adding second transport #7348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
link2xt
wants to merge
31
commits into
main
Choose a base branch
from
link2xt/multitransport
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9ca5385 to
d3a4eee
Compare
5 tasks
a288b16 to
d538e8f
Compare
3 tasks
b866d3e to
5d66931
Compare
5d66931 to
cbdae22
Compare
e2a6579 to
098c134
Compare
cbdae22 to
91c3957
Compare
91c3957 to
933903f
Compare
590cf06 to
22cdb13
Compare
5f75474 to
a2416ed
Compare
d90ed64 to
7fa3a69
Compare
7fa3a69 to
8bdc29d
Compare
Copilot finished reviewing on behalf of
link2xt
November 13, 2025 11:40
9bc7b8f to
61d132d
Compare
26af266 to
6151afc
Compare
6151afc to
c97938e
Compare
Collaborator
Author
|
This is now ready for review. It is a minimal support for multi-transport, allowing to add transports and switch between them while being connected to all of them over IMAP. It does not support synchronization, so adding transports should only be allowed when multi-device is not enabled ("bcc_self" is false). Most important to review is the SQL migration, everything else can be changed later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #7357
Based on (already merged) #7424, #7413, #7406, #7392
Adding second transport is only allowed with bcc_self disabled for now, synchronization of transports will be a separate PR. This PR is fine for adding multiple transports on a single-device setup already and switching between them.
Connectivity view will display something, but extending it for multi-transport is out of scope for this PR, this is in the tracking issue.
imaptableimap_synctableconfigured_addris setimapandimap_syncentries when the transport is deletedexamples/test_examples.py::test_echo_quit_plugin(disabled it, want to finish this PR instead of debugging legacy CFFI test)configured_addris changed or keep multiple SMTP connections until SMTP queue for non-primary transports is empty