Skip to content

is dc_stop_io() needed before dc_backup_provider_new() or not? #4176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #4180
r10s opened this issue Mar 19, 2023 · 3 comments · Fixed by #4182
Closed
Tracked by #4180

is dc_stop_io() needed before dc_backup_provider_new() or not? #4176

r10s opened this issue Mar 19, 2023 · 3 comments · Fixed by #4182

Comments

@r10s
Copy link
Contributor

r10s commented Mar 19, 2023

i am a bit confused - imu the gist of #4138 was to free the UI from the burden to care for start/stop IO.

i just wanted to clean up the corresponding code on iOS - but without stopping IO, creating a backuo provider fails with the error:

ERROR deltachat_repl > Failed to set up second device setup: Database export failed: cannot export backup, IO is running

i double checked that in the repl - send-backup does not work when connected.

or ist it still needed to stopIO manually and core will only take care that calls to startIO are void during backup transfer? (that would also be a win)

related to #4007

@link2xt
Copy link
Collaborator

link2xt commented Mar 19, 2023

Likely because #4007 was written independently, it does not use the call context.scheduler.pause which was only introduced in #4138. Now need to fix the backup transfer to use this call too and get pause guard rather than just checking that the scheduler is stopped. The pause guard is used in imex(), but not in the new functions. I added pause guard to get_backup() here: #4177 Need to also find a place where it should be in the sender side.

@gerryfrancis
Copy link
Collaborator

Maybe related: #2813

@link2xt
Copy link
Collaborator

link2xt commented Mar 19, 2023

Maybe related: #2813

Yes, #2813 is very likely fixed by #4138.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants