-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexible timeouts (for larger messages) #22
Comments
why does this need to live in this library and not be part of the way it is being used?
…On 8. Jun 2020, 09:45 +0200, Hocuri ***@***.***>, wrote:
For chatmail/core#1383 we need an different timeouts for larger messages.
The options I see are:
• function to reconfigure the timeout in runtime ***@***.*** didn't like this option)
• a functional-style setting .timeout_extra_time_per_mb( ...3 minutes... )
cc @link2xt @hpk42
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
How would you fix chatmail/core#1383 without modifying this library? |
@dignifiedquire A timeout should measure the time between last byte sent and |
So @link2xt @dignifiedquire which of the options would you say is better? Or something else?
|
I don't think mapping timeouts to message size belongs in this library. So what I would prefer is something like
|
|
Here is the list of timeouts: https://tools.ietf.org/html/rfc5321#section-4.5.3.2 We are interested in DATA Termination timeout here. |
For chatmail/core#1383 we need an different timeouts for larger messages.
The options I see are:
.timeout_extra_time_per_mb( ...3 minutes... )
cc @link2xt @hpk42
The text was updated successfully, but these errors were encountered: