Fix clippy warnings

Author: link2xt

.github/workflows/ci.yml

@@ -78,12 +78,7 @@ jobs:
   clippy_check:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
-      - uses: actions-rs/toolchain@v1
-        with:
-            toolchain: nightly
-            components: clippy
-            override: true
+      - uses: actions/checkout@v3
       - uses: actions-rs/clippy-check@v1
         with:
           token: ${{ secrets.GITHUB_TOKEN }}

benches/transport_smtp.rs

@@ -24,7 +24,7 @@ fn bench_simple_send(c: &mut Criterion) {
                     vec![EmailAddress::new("root@localhost".to_string()).unwrap()],
                 )
                 .unwrap(),
-                "id".to_string(),
+                "id",
                 "From: user@localhost\r\n\
                  Content-Type: text/plain\r\n\
                  \r\n\
@@ -55,7 +55,7 @@ fn bench_reuse_send(c: &mut Criterion) {
                     vec![EmailAddress::new("root@localhost".to_string()).unwrap()],
                 )
                 .unwrap(),
-                "id".to_string(),
+                "id",
                 "From: user@localhost\r\n\
                  Content-Type: text/plain\r\n\
                  \r\n\

examples/smtp.rs

@@ -9,7 +9,7 @@ fn main() {
                 vec![EmailAddress::new("root@localhost".to_string()).unwrap()],
             )
             .unwrap(),
-            "id".to_string(),
+            "id",
             "Hello ß☺ example".to_string().into_bytes(),
         );
 

examples/smtp_gmail.rs

@@ -9,7 +9,7 @@ fn main() {
                 vec![EmailAddress::new("[email protected]".to_string()).unwrap()],
             )
             .unwrap(),
-            "id".to_string(),
+            "id",
             "Hello example".to_string().into_bytes(),
         );
 

src/smtp/client/codec.rs

@@ -25,6 +25,7 @@ impl ClientCodec {
 impl ClientCodec {
     /// Adds transparency
     /// TODO: replace CR and LF by CRLF
+    #[allow(clippy::bool_to_int_with_if)]
     pub async fn encode<W: Write + Unpin>(&mut self, frame: &[u8], mut buf: W) -> io::Result<()> {
         match frame.len() {
             0 => {

src/smtp/commands.rs

@@ -312,7 +312,7 @@ impl AuthCommand {
             .ok_or(Error::ResponseParsing("Could not read auth challenge"))?;
         debug!("auth encoded challenge: {}", encoded_challenge);
 
-        let decoded_challenge = String::from_utf8(base64::decode(&encoded_challenge)?)?;
+        let decoded_challenge = String::from_utf8(base64::decode(encoded_challenge)?)?;
         debug!("auth decoded challenge: {}", decoded_challenge);
 
         let response = Some(mechanism.response(&credentials, Some(decoded_challenge.as_ref()))?);
@@ -383,7 +383,7 @@ mod test {
             "RCPT TO:<[email protected]>\r\n"
         );
         assert_eq!(
-            format!("{}", RcptCommand::new(email.clone(), vec![rcpt_parameter])),
+            format!("{}", RcptCommand::new(email, vec![rcpt_parameter])),
             "RCPT TO:<[email protected]> TEST=value\r\n"
         );
         assert_eq!(format!("{}", QuitCommand), "QUIT\r\n");
@@ -414,7 +414,7 @@ mod test {
         assert_eq!(
             format!(
                 "{}",
-                AuthCommand::new(Mechanism::Login, credentials.clone(), None).unwrap()
+                AuthCommand::new(Mechanism::Login, credentials, None).unwrap()
             ),
             "AUTH LOGIN\r\n"
         );

tests/transport_file.rs

@@ -18,7 +18,7 @@ mod test {
                     vec![EmailAddress::new("root@localhost".to_string()).unwrap()],
                 )
                     .unwrap(),
-                "id".to_string(),
+                "id",
                 "Hello ß☺ example".to_string().into_bytes(),
             );
             let message_id = email.message_id().to_string();

tests/transport_sendmail.rs

@@ -14,7 +14,7 @@ mod test {
                     vec![EmailAddress::new("root@localhost".to_string()).unwrap()],
                 )
                     .unwrap(),
-                "id".to_string(),
+                "id",
                 "Hello ß☺ example".to_string().into_bytes(),
             );
 

tests/transport_stub.rs

@@ -13,7 +13,7 @@ mod test {
                 vec![EmailAddress::new("root@localhost".to_string()).unwrap()],
             )
             .unwrap(),
-            "id".to_string(),
+            "id",
             "Hello ß☺ example".to_string().into_bytes(),
         );
         let email_ko = SendableEmail::new(
@@ -22,7 +22,7 @@ mod test {
                 vec![EmailAddress::new("root@localhost".to_string()).unwrap()],
             )
             .unwrap(),
-            "id".to_string(),
+            "id",
             "Hello ß☺ example".to_string().into_bytes(),
         );