pkg/sca/sca_test.go et al: Implement test for getLdSoConfDLibPaths

This commit implements a simple test to make sure that the new
function is properly parsing the configuration file inside
/etc/ld.so.conf.d/.

A small modification had to be made to the (th *testHandle)
RelativeNames() function in order to make TestDocSca pass,
because (th *testHandle) FilesystemForRelative() isn't implemented.

Signed-off-by: Sergio Durigan Junior <[email protected]>

Author: sergiodj

pkg/sca/sca_test.go

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+//go:generate go run ./../../ build --generate-index=false --out-dir=./testdata/generated ./testdata/ld-so-conf-d-test.yaml --arch=x86_64
 //go:generate go run ./../../ build --generate-index=false --out-dir=./testdata/generated ./testdata/shbang-test.yaml --arch=x86_64
 //go:generate go run ./../../ build --generate-index=false --source-dir=./testdata/go-fips-bin/ --out-dir=./testdata/generated ./testdata/go-fips-bin/go-fips-bin.yaml --arch=x86_64
 //go:generate curl -s -o ./testdata/py3-seaborn.yaml https://raw.githubusercontent.com/wolfi-dev/os/7a39ac1d0603a3561790ea2201dd8ad7c2b7e51e/py3-seaborn.yaml
@@ -56,7 +57,7 @@ func (th *testHandle) Version() string {
 
 func (th *testHandle) RelativeNames() []string {
 	// TODO: Support subpackages?
-	return []string{th.pkg.Origin}
+	return []string{th.pkg.Name}
 }
 
 func (th *testHandle) FilesystemForRelative(pkgName string) (SCAFS, error) {
@@ -337,3 +338,20 @@ func TestGetShbang(t *testing.T) {
 		}
 	}
 }
+
+func TestLdSoConfD(t *testing.T) {
+	ctx := slogtest.Context(t)
+	// Generated with `go generate ./...`
+	th := handleFromApk(ctx, t, "generated/x86_64/ld-so-conf-d-test-1-r1.apk", "ld-so-conf-d-test.yaml")
+	defer th.exp.Close()
+
+	if extraLibPaths, err := getLdSoConfDLibPaths(ctx, th); err != nil {
+		t.Fatal(err)
+	} else if extraLibPaths == nil {
+		t.Error("getLdSoConfDLibPaths: expected 'my/lib/test', got nil")
+	} else {
+		if extraLibPaths[0] != "my/lib/test" {
+			t.Errorf("getLdSoConfDLibPaths: expected 'my/lib/test', got '%s'", extraLibPaths[0])
+		}
+	}
+}

pkg/sca/testdata/generated/x86_64/ld-so-conf-d-test-1-r1.apk

@@ -0,0 +1,25 @@
+package:
+  name: ld-so-conf-d-test
+  version: 1
+  epoch: 1
+  description: ld.so.conf.d test
+  copyright:
+    - license: MIT
+
+environment:
+  contents:
+    repositories:
+      - https://packages.wolfi.dev/os
+    keyring:
+      - https://packages.wolfi.dev/os/wolfi-signing.rsa.pub
+    packages:
+      - build-base
+      - busybox
+
+pipeline:
+  - runs: |
+      mkdir -p "${{targets.destdir}}"/etc/ld.so.conf.d
+      echo "/my/lib/test" > "${{targets.destdir}}"/etc/ld.so.conf.d/ld-so-conf-d-test.conf
+
+update:
+  enabled: false