Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing anchor link references #1989

Merged
merged 3 commits into from
Jan 4, 2025
Merged

Conversation

SharpRake
Copy link
Collaborator

Type of change

This PR fixes a few anchor links that have changed since the recent Images section reorganization. I am also taking this opportunity to fix the URLs posted in #1736

What should this PR do?

Resolves #1736
Resolves https://github.com/chainguard-dev/internal/issues/4532

Why are we making this change?

404s are a bad look!

What are the acceptance criteria?

I'm also going to try to fix the workflow to notify someone other than Jamon when there are 404s

How should this PR be tested?

I'm editing links directly and fixing aliases where possible, Please confirm that these changes make sense

@SharpRake SharpRake requested a review from a team as a code owner January 3, 2025 19:03
Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for ornate-narwhal-088216 ready!

Name Link
🔨 Latest commit 6d82a3e
🔍 Latest deploy log https://app.netlify.com/sites/ornate-narwhal-088216/deploys/67783e8e3371d40008a3c5e0
😎 Deploy Preview https://deploy-preview-1989--ornate-narwhal-088216.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Mark Drake <[email protected]>
@SharpRake
Copy link
Collaborator Author

I just pushed a commit that fixes most of the 404s listed in #1736

@SharpRake
Copy link
Collaborator Author

Also changed the link checker issue assignee to myself.

Copy link
Member

@jamonation jamonation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice

@SharpRake SharpRake merged commit c412600 into chainguard-dev:main Jan 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chainlink] check links on edu.chainguard.dev
2 participants