chore: add metrics for preconf timings

Author: merklefruit

eth/catalyst/api.go

@@ -38,6 +38,7 @@ import (
 	"github.com/ethereum/go-ethereum/eth/ethconfig"
 	"github.com/ethereum/go-ethereum/internal/version"
 	"github.com/ethereum/go-ethereum/log"
+	"github.com/ethereum/go-ethereum/metrics"
 	"github.com/ethereum/go-ethereum/miner"
 	"github.com/ethereum/go-ethereum/node"
 	"github.com/ethereum/go-ethereum/params/forks"
@@ -160,6 +161,10 @@ type ConsensusAPI struct {
 	forkchoiceLock sync.Mutex // Lock for the forkChoiceUpdated method
 	newPayloadLock sync.Mutex // Lock for the NewPayload method
 
+	// Metrics
+	newFragV0Time  *metrics.Timer
+	sealFragV0Time *metrics.Timer
+	envV0Time      *metrics.Timer
 }
 
 // NewConsensusAPI creates a new consensus api for the given backend.
@@ -181,6 +186,11 @@ func newConsensusAPIWithoutHeartbeat(eth *eth.Ethereum) *ConsensusAPI {
 		localBlocks:       newPayloadQueue(),
 		invalidBlocksHits: make(map[common.Hash]int),
 		invalidTipsets:    make(map[common.Hash]*types.Header),
+
+		// Metrics
+		newFragV0Time:  metrics.GetOrRegisterTimer("engine/frag/new", nil),
+		sealFragV0Time: metrics.GetOrRegisterTimer("engine/frag/seal", nil),
+		envV0Time:      metrics.GetOrRegisterTimer("engine/frag/env", nil),
 	}
 	eth.Downloader().SetBadBlockCallback(api.setInvalidAncestor)
 	return api
@@ -1356,6 +1366,7 @@ func validateRequests(requests [][]byte) error {
 func (api *ConsensusAPI) NewFragV0(frag engine.SignedNewFrag) (string, error) {
 	log.Info("new frag received", "forBlock", frag.Frag.BlockNumber, "current", api.eth.BlockChain().CurrentBlock().Number)
 
+	start := time.Now()
 	api.eth.BlockChain().UnsealedBlockLock().Lock()
 	res, err := api.newFragV0(frag)
 	if err != nil {
@@ -1364,7 +1375,8 @@ func (api *ConsensusAPI) NewFragV0(frag engine.SignedNewFrag) (string, error) {
 	}
 	api.eth.BlockChain().UnsealedBlockLock().Unlock()
 
-	log.Info("new frag handled successfully")
+	api.newFragV0Time.Update(time.Since(start))
+	log.Info("new frag handled successfully", "time", time.Since(start))
 
 	return res, err
 }
@@ -1444,6 +1456,7 @@ func (api *ConsensusAPI) SealFragV0(seal engine.SignedSeal) (string, error) {
 		return engine.VALID, nil
 	}
 
+	start := time.Now()
 	api.eth.BlockChain().UnsealedBlockLock().Lock()
 	res, err := api.sealFragV0(seal)
 	if err != nil {
@@ -1452,6 +1465,9 @@ func (api *ConsensusAPI) SealFragV0(seal engine.SignedSeal) (string, error) {
 	}
 	api.eth.BlockChain().UnsealedBlockLock().Unlock()
 
+	api.sealFragV0Time.Update(time.Since(start))
+	log.Info("seal handled successfully", "time", time.Since(start))
+
 	return res, err
 }
 
@@ -1520,6 +1536,7 @@ func (api *ConsensusAPI) ValidateSealFragV0(preSealedBlock *types.Block, seal en
 func (api *ConsensusAPI) EnvV0(env engine.SignedEnv) (string, error) {
 	log.Info("env received", "forBlock", env.Env.Number, "current", api.eth.BlockChain().CurrentBlock().Number, "env", env.Env)
 
+	start := time.Now()
 	api.eth.BlockChain().UnsealedBlockLock().Lock()
 	res, err := api.envV0(env)
 	if err != nil {
@@ -1529,7 +1546,8 @@ func (api *ConsensusAPI) EnvV0(env engine.SignedEnv) (string, error) {
 	}
 	api.eth.BlockChain().UnsealedBlockLock().Unlock()
 
-	log.Info("env handled successfully")
+	api.envV0Time.Update(time.Since(start))
+	log.Info("env handled successfully", "time", time.Since(start))
 
 	return res, err
 }