Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise RTL styling #78

Closed
guywillis opened this issue Dec 14, 2023 · 2 comments · Fixed by #79
Closed

Optimise RTL styling #78

guywillis opened this issue Dec 14, 2023 · 2 comments · Fixed by #79
Assignees
@guywillis
Labels
enhancement released

Comments

@guywillis
Copy link
Contributor

Subject of the enhancement

The RTL styling present in the list.less file could be optimised a touch better by utilising the padding-inline-end property instead of the current approach.

The padding-inline-end property does not require an associated RTL version as the property inherits the body direction.

Current approach:

&__image-container {
  padding-right: @item-padding;

  .dir-rtl & {
    padding-right: inherit;
    padding-left: @item-padding;
  }
}

Proposed solution:

&__image-container {
  padding-inline-end: @item-padding;
}

Your environment

  • Master
@guywillis guywillis self-assigned this Dec 14, 2023
@guywillis guywillis mentioned this issue Dec 14, 2023
Merged
@guywillis guywillis changed the title Optimise RTL padding styling Optimise RTL styling Dec 15, 2023
kirsty-hames pushed a commit that referenced this issue Dec 15, 2023
@guywillis
Update: Updated RTL styling (fixes #78) #79
794b36a
github-actions bot pushed a commit that referenced this issue Dec 15, 2023
@semantic-release-bot
Chore(release): 5.4.0 [skip ci]
8716d83 
# [5.4.0](v5.3.3...v5.4.0) (2023-12-15)

### Update

* Updated RTL styling (fixes #78) #79 ([794b36a](794b36a)), closes [#78](#78) [#79](#79)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 5.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@oliverfoster
Copy link
Member

oliverfoster commented Dec 19, 2023 •
edited
Loading

Not ie11 compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guywillis guywillis

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update: Updated RTL styling (fixes #78) cgkineo/adapt-list
2 participants
@oliverfoster @guywillis