Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLEIF links should show as "external" #1068

Open
4 of 7 tasks
meissadia opened this issue Nov 19, 2024 · 2 comments
Open
4 of 7 tasks

GLEIF links should show as "external" #1068

meissadia opened this issue Nov 19, 2024 · 2 comments
Assignees
@meissadia

Comments

@meissadia
Copy link
Contributor

meissadia commented Nov 19, 2024 •
edited
Loading

  • Relies on this DSR fix
  • GLEIF Links shown as external
    • Unauthenticated landing page
      Image
    • Update financial profile
      • Image
    • Complete your user profile
      Image
  • GLEIF link INTENTIONALLY NOT shown as external
    • View Institution Profile - LEI registration status == "Not provided" or "Lapsed"
      Image
@meissadia meissadia self-assigned this Nov 19, 2024
@meissadia
Copy link
Contributor Author

I think this is implemented but need to verify

@meissadia
Copy link
Contributor Author

I've added screenshots above for each GLEIF link I found in the app.

  • 3 links show as external, as expected
  • @natalia-fitzgerald 1 link is explicitly marked to not display the external icon, just want to confirm this is still the desired display.

Happy to chat/demo if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meissadia meissadia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@meissadia