From 1d9d0002c781c1d4f67ab887273d03023ec5b67e Mon Sep 17 00:00:00 2001 From: bsharma Date: Wed, 18 Nov 2020 12:35:22 -0500 Subject: [PATCH] change name and add application date to the edit detail --- common/src/main/resources/reference.conf | 4 ++-- .../{submission-errors.sql => triggered_quality_edits.sql} | 4 ++-- submission-errors/src/main/resources/application.conf | 2 +- .../main/scala/hmda/submissionerrors/streams/ErrorLines.scala | 4 ++-- submission-errors/src/test/resources/bootstrap.sql | 4 ++-- .../repositories/PostgresSubmissionErrorRepositorySpec.scala | 2 +- 6 files changed, 10 insertions(+), 10 deletions(-) rename hmda-sql-doc/{submission-errors.sql => triggered_quality_edits.sql} (64%) diff --git a/common/src/main/resources/reference.conf b/common/src/main/resources/reference.conf index 21085889f2..f284cf4a44 100644 --- a/common/src/main/resources/reference.conf +++ b/common/src/main/resources/reference.conf @@ -163,8 +163,8 @@ hmda { irsGroup = ${?KAFKA_IRS_GROUP} institutionsGroup = "institutions-group" institutionsGroup = ${?KAFKA_INSTITUTIONS_GROUP} - submissionErrorsGroup = "submission-errors-group" - submissionErrorsGroup = ${?KAFKA_SUBMISSION_ERRORS_GROUP} + submissionErrorsGroup = "triggered-quality-edits-group" + submissionErrorsGroup = ${?TRIGGERED_QUALITY_EDITS_GROUP} } } } diff --git a/hmda-sql-doc/submission-errors.sql b/hmda-sql-doc/triggered_quality_edits.sql similarity index 64% rename from hmda-sql-doc/submission-errors.sql rename to hmda-sql-doc/triggered_quality_edits.sql index bfb4e70d2a..c1172aad98 100644 --- a/hmda-sql-doc/submission-errors.sql +++ b/hmda-sql-doc/triggered_quality_edits.sql @@ -1,4 +1,4 @@ -CREATE TABLE submission_errors( +CREATE TABLE triggered_quality_edits( lei VARCHAR, period VARCHAR, sequence_number INT, @@ -7,5 +7,5 @@ CREATE TABLE submission_errors( loan_data TEXT ARRAY, created_date TIMESTAMP, updated_date TIMESTAMP, - CONSTRAINT submission_errors_pkey PRIMARY KEY (lei, period, sequence_number, edit_name) + CONSTRAINT triggered_quality_edits_pkey PRIMARY KEY (lei, period, sequence_number, edit_name) ); \ No newline at end of file diff --git a/submission-errors/src/main/resources/application.conf b/submission-errors/src/main/resources/application.conf index 634cfbe0e9..05a3311d51 100644 --- a/submission-errors/src/main/resources/application.conf +++ b/submission-errors/src/main/resources/application.conf @@ -33,7 +33,7 @@ dbconfig { database = "hmda" database = ${?PG_DATABASE} - table = "submission_errors" + table = "triggered_quality_edits" table = ${?PG_TABLE} user = "postgres" diff --git a/submission-errors/src/main/scala/hmda/submissionerrors/streams/ErrorLines.scala b/submission-errors/src/main/scala/hmda/submissionerrors/streams/ErrorLines.scala index 1c984a06c8..881a149010 100644 --- a/submission-errors/src/main/scala/hmda/submissionerrors/streams/ErrorLines.scala +++ b/submission-errors/src/main/scala/hmda/submissionerrors/streams/ErrorLines.scala @@ -21,7 +21,7 @@ import scala.concurrent.Future object ErrorLines { type RawLine = String - final case class RowLoanData(uli: String, actionTaken: Int, actionTakenDate: Int) { + final case class RowLoanData(uli: String, actionTaken: Int, actionTakenDate: Int, applicationDate: String) { override def toString: String = s"$uli:$actionTaken:$actionTakenDate``" } @@ -65,7 +65,7 @@ object ErrorLines { case Some(editNames) => // only parse the line if we found that there was an error associated with it val lar = LarCsvParser(rawData).getOrElse(LoanApplicationRegister()) - val loanData = RowLoanData(lar.loan.ULI, lar.action.actionTakenType.code, lar.action.actionTakenDate) + val loanData = RowLoanData(lar.loan.ULI, lar.action.actionTakenType.code, lar.action.actionTakenDate, lar.loan.applicationDate) editNames.foldLeft(acc) { (acc, nextEditName) => val updatedErrorListForEdit = acc.getOrElse(nextEditName, Vector.empty[RowLoanData]) :+ loanData acc + (nextEditName -> updatedErrorListForEdit) diff --git a/submission-errors/src/test/resources/bootstrap.sql b/submission-errors/src/test/resources/bootstrap.sql index bfb4e70d2a..c1172aad98 100644 --- a/submission-errors/src/test/resources/bootstrap.sql +++ b/submission-errors/src/test/resources/bootstrap.sql @@ -1,4 +1,4 @@ -CREATE TABLE submission_errors( +CREATE TABLE triggered_quality_edits( lei VARCHAR, period VARCHAR, sequence_number INT, @@ -7,5 +7,5 @@ CREATE TABLE submission_errors( loan_data TEXT ARRAY, created_date TIMESTAMP, updated_date TIMESTAMP, - CONSTRAINT submission_errors_pkey PRIMARY KEY (lei, period, sequence_number, edit_name) + CONSTRAINT triggered_quality_edits_pkey PRIMARY KEY (lei, period, sequence_number, edit_name) ); \ No newline at end of file diff --git a/submission-errors/src/test/scala/hmda/submissionerrors/repositories/PostgresSubmissionErrorRepositorySpec.scala b/submission-errors/src/test/scala/hmda/submissionerrors/repositories/PostgresSubmissionErrorRepositorySpec.scala index 3202a7dcc1..1b86f67328 100644 --- a/submission-errors/src/test/scala/hmda/submissionerrors/repositories/PostgresSubmissionErrorRepositorySpec.scala +++ b/submission-errors/src/test/scala/hmda/submissionerrors/repositories/PostgresSubmissionErrorRepositorySpec.scala @@ -20,7 +20,7 @@ class PostgresSubmissionErrorRepositorySpec "PostgresSubmissionErrorRepository" should "persist error data into the repository" in { // Note: dbConfig comes from EmbeddedPostgres val dbConfig = PostgresSubmissionErrorRepository.config(dbHoconpath) - val repo = PostgresSubmissionErrorRepository.make(dbConfig, "submission_errors") + val repo = PostgresSubmissionErrorRepository.make(dbConfig, "triggered_quality_edits") val submissionId = SubmissionId("EXAMPLE-LEI", Period(2018, None), sequenceNumber = 1) repo.submissionPresent(submissionId).runSyncUnsafe() shouldBe false