Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up initial render and hydration of pfc grad path #8226

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Conversation

wpears
Copy link
Member

@wpears wpears commented Mar 14, 2024

Closes #8219

This PR does two things:

  • Adds and utilizes some bulk updating methods to prevent unnecessary recalculations (primarily in the financial model). Recalculations in the models only happen after all the data has been seeded from the params.
  • Checks the radio buttons on the landing page directly instead of emitting clicks (which then trigger a bunch of unneeded/unnecessary events and processing logic)/

Testing

  • Visit prod in one window. It will be very slow to both initially load and then to populate the radio buttons (5-15s for each)
  • Pull, build, fire up localhost and visit localhost:8000. Loading should be much faster, as should populating the radio buttons. (1-2s)

@wpears wpears requested review from mistergone and contolini March 14, 2024 17:51
chosak
chosak previously approved these changes Mar 14, 2024
Copy link
Member

@chosak chosak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Pasted on the wrong PR. 🤦

@chosak chosak dismissed their stale review March 14, 2024 18:13

Pasted on wrong PR!

Copy link
Member

@mistergone mistergone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@wpears wpears added this pull request to the merge queue Mar 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 15, 2024
@contolini
Copy link
Member

I haven't been able to figure out why but I'm seeing unrendered tags locally:

image

@chosak
Copy link
Member

chosak commented Mar 21, 2024

Ping @willbarton, could this be related to some of the raw HTML remediation work?

@wpears
Copy link
Member Author

wpears commented Mar 21, 2024

This should have been fixed via #8224

I'm updating this branch. @contolini can you pull and re-try?

@wpears wpears enabled auto-merge March 21, 2024 15:36
Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐎 💨

@wpears wpears added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit 528396e Mar 21, 2024
11 checks passed
@wpears wpears deleted the pfc-perf branch March 21, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PfC: Routing implementation causes long page loads
4 participants