Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PfC: Routing implementation causes long page loads #8219

Closed
contolini opened this issue Mar 12, 2024 · 0 comments · Fixed by #8226
Closed

PfC: Routing implementation causes long page loads #8219

contolini opened this issue Mar 12, 2024 · 0 comments · Fixed by #8226
Assignees

Comments

@contolini
Copy link
Member

PfC permalinks result in long page load times (15+ seconds) due to expensive calculations occurring when parseQueryParameters is called. Not only is this problematic for our users but it causes our Cypress tests to take a long time to complete.

Steps to replicate behavior

  1. Visit a PfC link that has saved college values, here's an example.
  2. Notice how the URL query params update sequentially in the browser bar and the page takes a long time to render.

Screenshots

url dance intimidating flame chart
pfc image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants