Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove external link interstitial functionality 🎉 #8095

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

anselmbradford
Copy link
Member

Fixes #7845

Removals

  • Removes external link interstitial functionality 🎉

How to test this PR

  1. PR checks should pass.
  2. Any external link should get an external link icon, but not have an interstitial.

Copy link
Member

@willbarton willbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing that can also go, but I think this looks good!

I think I had repressed or blocked out any knowledge of data-pretty-href, and it makes me 😱 .

cfgov/core/utils.py Outdated Show resolved Hide resolved
Copy link
Member

@chosak chosak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

+1 to Will's suggestion, but besides, that, this looks great! PR of the year so far!

@anselmbradford anselmbradford added this pull request to the merge queue Jan 24, 2024
Merged via the queue into main with commit c945b68 Jan 24, 2024
15 of 16 checks passed
@anselmbradford anselmbradford deleted the ans_remove_interstitial branch January 24, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External links should not go through interstitial page
3 participants