Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch before-you-claim to use fetch instead of jquery ajax #7653

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Switch before-you-claim to use fetch instead of jquery ajax #7653

merged 2 commits into from
Apr 12, 2023

Conversation

wpears
Copy link
Member

@wpears wpears commented Apr 11, 2023

Closes #7390

Testing:

@wpears wpears requested a review from anselmbradford April 11, 2023 21:54
anselmbradford
anselmbradford reviewed Apr 12, 2023
View reviewed changes
cfgov/unprocessed/apps/retirement/js/views/graph-view.js
import getModelValues from '../wizards/get-model-values.js';
import update from '../wizards/update-model.js';
Copy link
Member

@anselmbradford anselmbradford Apr 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be named updateModel to match naming of the other imports. update is rather generic.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a large-ish thing brewing for this, will actually open a new PR ^__^

anselmbradford
anselmbradford approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@anselmbradford anselmbradford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. Otherwise works great!

@wpears wpears added this pull request to the merge queue Apr 12, 2023
Merged via the queue into main with commit 7b6190d Apr 12, 2023
@wpears wpears deleted the retirement-to-fetch branch April 12, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anselmbradford anselmbradford anselmbradford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retirement: migrate jquery ajax call to fetch
2 participants
@wpears @anselmbradford