Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove base-common.html #5154

Merged
merged 2 commits into from
Aug 1, 2019
Merged

Remove base-common.html #5154

merged 2 commits into from
Aug 1, 2019

Conversation

anselmbradford
Copy link
Member

Fixes #5132

Changes

  • Merges base-common.html into base.html.

Testing

  1. Pull branch, run serve, check site. It should work like production.

wpears
wpears approved these changes Aug 1, 2019
View reviewed changes
Copy link
Member

@wpears wpears left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@anselmbradford anselmbradford merged commit 07243a8 into master Aug 1, 2019
@anselmbradford anselmbradford deleted the ans_remove_base_common branch August 1, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpears wpears wpears approved these changes

@cfarm cfarm Awaiting requested review from cfarm

@virginiacc virginiacc Awaiting requested review from virginiacc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge base-common.html and base.html
2 participants
@anselmbradford @wpears