Open
Conversation
stu-k
suggested changes
Oct 20, 2017
stu-k
left a comment
stu-k
left a comment
There was a problem hiding this comment.
#solidwork on your input scrubbing and string methods. Your else statement assumes that if the first letter isn't a vowel, the second one is. This isn't always true! This test on line 46 is failing because of this.
| // Your code here | ||
|
|
||
| // make (word) all lowercase | ||
| const lowerThatCase = word.toLowerCase().trim(); |
| // make that into array | ||
| const splitWord = lowerThatCase.split(''); | ||
| // check if any vowels if not move on to normalcy | ||
| if (splitWord[0] === 'a' || splitWord[0] === 'e' || splitWord[0] === 'i' || splitWord[0] === 'o' || splitWord[0] === 'u'){ |
There was a problem hiding this comment.
Using what you now know about .indexOf(), this could be simplified.
| // check if any vowels if not move on to normalcy | ||
| if (splitWord[0] === 'a' || splitWord[0] === 'e' || splitWord[0] === 'i' || splitWord[0] === 'o' || splitWord[0] === 'u'){ | ||
| return lowerThatCase + 'yay'; | ||
| } else { |
There was a problem hiding this comment.
This else statement runs after the first letter is determined to not be a vowell, but then assumes the next letter is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkpoint Rubric
This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.
Checkpoint 1
Checkpoint 2
Checkpoint 3