Skip to content
This repository was archived by the owner on Oct 1, 2024. It is now read-only.

Commit 3dae1bc

Browse files
author
Jim Heising
committed
Fixed an issue where a setting might be updated more than once
1 parent fdc3464 commit 3dae1bc

7 files changed

+16
-7
lines changed

js/freeboard+plugins.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -2152,7 +2152,10 @@ function WidgetModel(theFreeboardModel, widgetPlugins) {
21522152
self.datasourceRefreshNotifications[dsName] = refreshSettingNames;
21532153
}
21542154

2155-
refreshSettingNames.push(settingDef.name);
2155+
if(_.indexOf(refreshSettingNames, settingDef.name) == -1) // Only subscribe to this notification once.
2156+
{
2157+
refreshSettingNames.push(settingDef.name);
2158+
}
21562159
}
21572160
}
21582161
}

js/freeboard+plugins.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

js/freeboard+plugins.min.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

js/freeboard.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -2152,7 +2152,10 @@ function WidgetModel(theFreeboardModel, widgetPlugins) {
21522152
self.datasourceRefreshNotifications[dsName] = refreshSettingNames;
21532153
}
21542154

2155-
refreshSettingNames.push(settingDef.name);
2155+
if(_.indexOf(refreshSettingNames, settingDef.name) == -1) // Only subscribe to this notification once.
2156+
{
2157+
refreshSettingNames.push(settingDef.name);
2158+
}
21562159
}
21572160
}
21582161
}

js/freeboard.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

js/freeboard.min.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/js/freeboard/WidgetModel.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,10 @@ function WidgetModel(theFreeboardModel, widgetPlugins) {
152152
self.datasourceRefreshNotifications[dsName] = refreshSettingNames;
153153
}
154154

155-
refreshSettingNames.push(settingDef.name);
155+
if(_.indexOf(refreshSettingNames, settingDef.name) == -1) // Only subscribe to this notification once.
156+
{
157+
refreshSettingNames.push(settingDef.name);
158+
}
156159
}
157160
}
158161
}

0 commit comments

Comments
 (0)