Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: optional verbosity of license checker script #3716

Open
tiborsimko opened this issue Jan 6, 2025 · 0 comments
Open

ci: optional verbosity of license checker script #3716

tiborsimko opened this issue Jan 6, 2025 · 0 comments

Comments

@tiborsimko
Copy link
Member

Current behaviour

The license checker helper script output is rather verbose currently:

$ ./scripts/check_licenses.py
[INFO] Successfully validated file LHCb_2011_Beam3500GeV_VeloClosed_MagDown_RealData_Reco14_Stripping21r1_BHADRONCOMPLETEEVENT_DST.json
[INFO] Successfully validated file LHCb_2011_Beam3500GeV_VeloClosed_MagDown_RealData_Reco14_Stripping21r1_BHADRON_MDST.json
[INFO] Successfully validated file LHCb_2011_Beam3500GeV_VeloClosed_MagDown_RealData_Reco14_Stripping21r1_CHARMCOMPLETEEVENT_DST.json
[INFO] Successfully validated file LHCb_2011_Beam3500GeV_VeloClosed_MagDown_RealData_Reco14_Stripping21r1_CHARM_MDST.json
...
[INFO] Successfully validated file delphi-datasets-1999.json
[INFO] Successfully validated file lhcb-antimatter-matters-2017.json
[INFO] Successfully validated file delphi-datasets-1995.json
[INFO] Successfully validated file opera-detector-events-tau.json
[INFO] Processed 328 files within 1.86 seconds.
[INFO] Successfully validated 25203 records. No errors found.

This is unlike typical linting tools, such as flake8, markdownlint, etc, which are usually quiet by default.

Expected behaviour

Let's print out only "error" and "warning" type of messages by the license checker, so that it would behave similarly to other linting tools out there.

The script can allow user to increase verbosity (e.g. by means of a -v command-line option) if the user would like to see also the "info" type of messages and statistics about which files were processed, how much time the execution took, and how many values were validated in each file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant