Changed logic to decide whether an account is Primary

cernbox · Nov 25, 2024 · b9cb1db · b9cb1db
1 parent 9969421
commit b9cb1db
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/user/rest.go b/user/rest.go
@@ -185,8 +185,10 @@ func (i *Identity) UserType() userpb.UserType {
 	case "Secondary":
 		return userpb.UserType_USER_TYPE_SECONDARY
 	case "Person":
-		if i.Source == "cern" && i.ActiveUser {
-			// this is a CERN account; incidentally, also i.UID > 0 qualifies for that
+		if i.Source == "cern" && i.UID > 0 {
+			// this is a CERN account; here we should check if i.ActiveUser = true,
+			// but users that have just left the Organization have ActiveUser = false,
+			// whereas users with UID = 0 are definitely non-primary.
 			return userpb.UserType_USER_TYPE_PRIMARY
 		}
 		return userpb.UserType_USER_TYPE_LIGHTWEIGHT // external user