Better error handling

jessegeens · jessegeens · commit 58d68e671398 · 2025-01-13T13:32:51.000+01:00
diff --git a/share/sql/sql.go b/share/sql/sql.go
@@ -329,6 +329,13 @@ func (m *mgr) getPath(ctx context.Context, resID *provider.ResourceId) (string,
 		return "", err
 	}
 
+	if res.Status.Code == rpc.Code_CODE_OK {
+		return res.GetPath(), nil
+	} else if res.Status.Code == rpc.Code_CODE_NOT_FOUND {
+		return "", errtypes.NotFound(resID.OpaqueId)
+	}
+	return "", errors.New(res.Status.Code.String() + ": " + res.Status.Message)
+
 	return res.GetPath(), nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -329,6 +329,13 @@ func (m mgr) getPath(ctx context.Context, resID provider.ResourceId) (string,`
`329`	`329`	`return "", err`
`330`	`330`	`}`
`331`	`331`
	`332`	`+ if res.Status.Code == rpc.Code_CODE_OK {`
	`333`	`+ return res.GetPath(), nil`
	`334`	`+ } else if res.Status.Code == rpc.Code_CODE_NOT_FOUND {`
	`335`	`+ return "", errtypes.NotFound(resID.OpaqueId)`
	`336`	`+ }`
	`337`	`+ return "", errors.New(res.Status.Code.String() + ": " + res.Status.Message)`
	`338`	`+`
`332`	`339`	`return res.GetPath(), nil`
`333`	`340`	`}`
`334`	`341`