From e1349ec011eaef19d3b2e6037fb027f6a6d2b6f9 Mon Sep 17 00:00:00 2001
From: Guilherme Amadio <amadio@cern.ch>
Date: Tue, 26 Nov 2024 14:02:52 +0100
Subject: [PATCH] [XrdOss] Fix CodeQL warning about int overflow in
 multiplication

The multiplication is numq * xfrovhd, which if carried with ints
can overflow before being converted to unsigned long long. Convert
one of the operands to unsigned long long to avoid this.
---
 src/XrdOss/XrdOssStage.cc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/XrdOss/XrdOssStage.cc b/src/XrdOss/XrdOssStage.cc
index 4fad9b7dde3..539030489a7 100644
--- a/src/XrdOss/XrdOssStage.cc
+++ b/src/XrdOss/XrdOssStage.cc
@@ -393,8 +393,9 @@ int XrdOssSys::CalcTime()
 
 int XrdOssSys::CalcTime(XrdOssStage_Req *req) // StageMutex lock held!
 {
+    unsigned long long numq = 1;
     unsigned long long tbytes = req->size + stgbytes/2;
-    int xfrtime, numq = 1;
+    int xfrtime;
     time_t now;
     XrdOssStage_Req *rqp = req;