Skip uncle hash check for pre gingerbread headers

piersy · piersy · commit bc6fe0f52102 · 2024-06-24T12:16:44.000+01:00
Pre gingerbread headers do not have a valid uncle hash because they have
no notion of uncles.
diff --git a/eth/downloader/queue.go b/eth/downloader/queue.go
@@ -782,7 +782,8 @@ func (q *queue) DeliverBodies(id string, txLists [][]*types.Transaction, txListH
 		if txListHashes[index] != header.TxHash {
 			return errInvalidBody
 		}
-		if uncleListHashes[index] != header.UncleHash {
+		// Pre gingerbread headers do not have a valid uncle hash.
+		if !header.IsPreGingerbread() && uncleListHashes[index] != header.UncleHash {
 			return errInvalidBody
 		}
 		if header.WithdrawalsHash == nil {

Original file line number	Diff line number	Diff line change
`@@ -782,7 +782,8 @@ func (q queue) DeliverBodies(id string, txLists [][]types.Transaction, txListH`
`782`	`782`	`if txListHashes[index] != header.TxHash {`
`783`	`783`	`return errInvalidBody`
`784`	`784`	`}`
`785`		`- if uncleListHashes[index] != header.UncleHash {`
	`785`	`+ // Pre gingerbread headers do not have a valid uncle hash.`
	`786`	`+ if !header.IsPreGingerbread() && uncleListHashes[index] != header.UncleHash {`
`786`	`787`	`return errInvalidBody`
`787`	`788`	`}`
`788`	`789`	`if header.WithdrawalsHash == nil {`