Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support or remove SignedTypedMessage on celo's ledger app #1760

Open
mcortesi opened this issue Dec 1, 2021 · 1 comment
Open

Support or remove SignedTypedMessage on celo's ledger app #1760

mcortesi opened this issue Dec 1, 2021 · 1 comment

Comments

@mcortesi
Copy link
Contributor

mcortesi commented Dec 1, 2021

Description

Add support or remove

On ledger.go

/* TODO: add functionality to the Ledger's Celo app
// SignTypedMessage implements usbwallet.driver, sending the message to the Ledger and
// waiting for the user to sign or deny the transaction.
//
// Note: this was introduced in the ledger 1.5.0 firmware
func (w *ledgerDriver) SignTypedMessage(path accounts.DerivationPath, domainHash []byte, messageHash []byte) ([]byte, error) {
	// If the Ethereum app doesn't run, abort
	if w.offline() {
		return nil, accounts.ErrWalletClosed
	}
	// Ensure the wallet is capable of signing the given transaction
	if w.version[0] < 1 && w.version[1] < 5 {
		//lint:ignore ST1005 brand name displayed on the console
		return nil, fmt.Errorf("Ledger version >= 1.5.0 required for EIP-712 signing (found version v%d.%d.%d)", w.version[0], w.version[1], w.version[2])
	}
	// All infos gathered and metadata checks out, request signing
	return w.ledgerSignTypedMessage(path, domainHash, messageHash)
}
*/

Context

Leftover 1.10.7 merge

@mcortesi mcortesi mentioned this issue Dec 2, 2021
@carterqw2 carterqw2 added triage Issue needs triaging and removed blockchain labels Feb 9, 2023
@carterqw2 carterqw2 removed the triage Issue needs triaging label Feb 16, 2023
@palango
Copy link
Collaborator

palango commented Mar 18, 2025

@mcortesi Any idea if this is something we still need to look into?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants