Define ToCeloFn type

The declaration is repeated multiple times and I am about to change it,
so it is nice to pull it into a typedef.

Author: karlb

core/types/transaction.go

@@ -541,11 +541,12 @@ type TxWithMinerFee struct {
 	tx       *Transaction
 	minerFee *big.Int // in CELO
 }
+type ToCELOFn func(amount *big.Int, feeCurrency *common.Address) *big.Int
 
 // NewTxWithMinerFee creates a wrapped transaction, calculating the effective
 // miner gasTipCap if a base fee is provided. The MinerFee is converted to CELO.
 // Returns error in case of a negative effective miner gasTipCap.
-func NewTxWithMinerFee(tx *Transaction, baseFeeFn func(feeCurrency *common.Address) *big.Int, toCELO func(amount *big.Int, feeCurrency *common.Address) *big.Int) (*TxWithMinerFee, error) {
+func NewTxWithMinerFee(tx *Transaction, baseFeeFn func(feeCurrency *common.Address) *big.Int, toCELO ToCELOFn) (*TxWithMinerFee, error) {
 	minerFee, err := tx.EffectiveGasTip(baseFeeFn(tx.FeeCurrency()))
 	if err != nil {
 		return nil, err
@@ -588,11 +589,11 @@ func (s *TxByPriceAndTime) Pop() interface{} {
 // transactions in a profit-maximizing sorted order, while supporting removing
 // entire batches of transactions for non-executable accounts.
 type TransactionsByPriceAndNonce struct {
-	txs       map[common.Address]Transactions                             // Per account nonce-sorted list of transactions
-	heads     TxByPriceAndTime                                            // Next transaction for each unique account (price heap)
-	signer    Signer                                                      // Signer for the set of transactions
-	baseFeeFn func(feeCurrency *common.Address) *big.Int                  // Function to get the basefee for the specified feecurrency.
-	toCELO    func(amount *big.Int, feeCurrency *common.Address) *big.Int // Current exchange rate to CELO
+	txs       map[common.Address]Transactions            // Per account nonce-sorted list of transactions
+	heads     TxByPriceAndTime                           // Next transaction for each unique account (price heap)
+	signer    Signer                                     // Signer for the set of transactions
+	baseFeeFn func(feeCurrency *common.Address) *big.Int // Function to get the basefee for the specified feecurrency.
+	toCELO    ToCELOFn                                   // Current exchange rate to CELO
 }
 
 // NewTransactionsByPriceAndNonce creates a transaction set that can retrieve
@@ -601,7 +602,7 @@ type TransactionsByPriceAndNonce struct {
 // Note, the input map is reowned so the caller should not interact any more with
 // if after providing it to the constructor.
 // Note: txCmpFunc should handle the basefee
-func NewTransactionsByPriceAndNonce(signer Signer, txs map[common.Address]Transactions, baseFeeFn func(feeCurrency *common.Address) *big.Int, toCELO func(amount *big.Int, feeCurrency *common.Address) *big.Int) *TransactionsByPriceAndNonce {
+func NewTransactionsByPriceAndNonce(signer Signer, txs map[common.Address]Transactions, baseFeeFn func(feeCurrency *common.Address) *big.Int, toCELO ToCELOFn) *TransactionsByPriceAndNonce {
 	// Initialize a price and received time based heap with the head transactions
 	heads := make(TxByPriceAndTime, 0, len(txs))
 	for from, accTxs := range txs {

miner/block.go

@@ -364,7 +364,7 @@ func (b *blockState) finalizeAndAssemble(w *worker) (*types.Block, error) {
 }
 
 // totalFees computes total consumed fees in CELO. Block transactions and receipts have to have the same order.
-func totalFees(block *types.Block, receipts []*types.Receipt, baseFeeFn func(*common.Address) *big.Int, toCELO func(*big.Int, *common.Address) *big.Int, espresso bool) *big.Float {
+func totalFees(block *types.Block, receipts []*types.Receipt, baseFeeFn func(*common.Address) *big.Int, toCELO types.ToCELOFn, espresso bool) *big.Float {
 	feesWei := new(big.Int)
 	for i, tx := range block.Transactions() {
 		var basefee *big.Int
@@ -379,7 +379,7 @@ func totalFees(block *types.Block, receipts []*types.Receipt, baseFeeFn func(*co
 
 // createConversionFunctions creates a function to convert any currency to Celo and a function to get the gas price minimum for that currency.
 // Both functions internally cache their results.
-func createConversionFunctions(sysCtx *core.SysContractCallCtx, chain *core.BlockChain, header *types.Header, state *state.StateDB) (func(feeCurrency *common.Address) *big.Int, func(amount *big.Int, feeCurrency *common.Address) *big.Int) {
+func createConversionFunctions(sysCtx *core.SysContractCallCtx, chain *core.BlockChain, header *types.Header, state *state.StateDB) (func(feeCurrency *common.Address) *big.Int, types.ToCELOFn) {
 	vmRunner := chain.NewEVMRunner(header, state)
 	currencyManager := currency.NewManager(vmRunner)