Return errors from toCeloFn

#2134 leads us to
believe that there are failures happening in production. This change
* Handles error cases by skipping processing of respective txs instead
  of segfaulting
* Logs tx information in these cases to better understand why this is
  happening

Skipping transactions where conversion is not possible is analogous to
handling other cases of bad transactions. But since the linked issue
only happens for some nodes, I am not sure if this is the right thing to
do or if we should intentionally panic in that case to avoid harder to
debug consensus failures due to having different nodes process a
different set of transactions.

Author: karlb

core/types/transaction.go

@@ -549,7 +549,7 @@ type TxWithMinerFee struct {
 	tx       *Transaction
 	minerFee *big.Int // in CELO
 }
-type ToCELOFn func(amount *big.Int, feeCurrency *common.Address) *big.Int
+type ToCELOFn func(amount *big.Int, feeCurrency *common.Address) (*big.Int, error)
 
 // NewTxWithMinerFee creates a wrapped transaction, calculating the effective
 // miner gasTipCap if a base fee is provided. The MinerFee is converted to CELO.
@@ -559,9 +559,14 @@ func NewTxWithMinerFee(tx *Transaction, baseFeeFn func(feeCurrency *common.Addre
 	if err != nil {
 		return nil, err
 	}
+	minerFeeInCelo, err := toCELO(minerFee, tx.FeeCurrency())
+	if err != nil {
+		log.Error("NewTxWithMinerFee: Could not convert fees for tx", "tx", tx, "err", err)
+		return nil, err
+	}
 	return &TxWithMinerFee{
 		tx:       tx,
-		minerFee: toCELO(minerFee, tx.FeeCurrency()),
+		minerFee: minerFeeInCelo,
 	}, nil
 }
 

core/types/transaction_test.go

@@ -397,8 +397,8 @@ func TestTxEthCompatible(t *testing.T) {
 }
 
 // toCELO converter assuming that feeCurrency is always nil
-func toCELOMockFn(amount *big.Int, feeCurrency *common.Address) *big.Int {
-	return amount
+func toCELOMockFn(amount *big.Int, feeCurrency *common.Address) (*big.Int, error) {
+	return amount, nil
 }
 
 func TestTransactionPriceNonceSortLegacy(t *testing.T) {

miner/block.go

@@ -394,7 +394,11 @@ func totalFees(block *types.Block, receipts []*types.Receipt, baseFeeFn func(*co
 		if espresso {
 			basefee = baseFeeFn(tx.FeeCurrency())
 		}
-		fee := toCELO(new(big.Int).Mul(new(big.Int).SetUint64(receipts[i].GasUsed), tx.EffectiveGasTipValue(basefee)), tx.FeeCurrency())
+		fee, err := toCELO(new(big.Int).Mul(new(big.Int).SetUint64(receipts[i].GasUsed), tx.EffectiveGasTipValue(basefee)), tx.FeeCurrency())
+		if err != nil {
+			log.Error("totalFees: Could not convert fees for tx", "tx", tx, "err", err)
+			continue
+		}
 		feesWei.Add(feesWei, fee)
 	}
 	return new(big.Float).Quo(new(big.Float).SetInt(feesWei), new(big.Float).SetInt(big.NewInt(params.Ether)))
@@ -409,12 +413,12 @@ func createConversionFunctions(sysCtx *core.SysContractCallCtx, chain *core.Bloc
 	baseFeeFn := func(feeCurrency *common.Address) *big.Int {
 		return sysCtx.GetGasPriceMinimum(feeCurrency)
 	}
-	toCeloFn := func(amount *big.Int, feeCurrency *common.Address) *big.Int {
+	toCeloFn := func(amount *big.Int, feeCurrency *common.Address) (*big.Int, error) {
 		curr, err := currencyManager.GetCurrency(feeCurrency)
 		if err != nil {
-			log.Error("toCeloFn: could not get currency", "err", err)
+			return nil, fmt.Errorf("toCeloFn: %w", err)
 		}
-		return curr.ToCELO(amount)
+		return curr.ToCELO(amount), nil
 	}
 
 	return baseFeeFn, toCeloFn