From e7132ca1916a6fd78034d7da705a6798d31fb0af Mon Sep 17 00:00:00 2001 From: CatLover <152669316+catloversg@users.noreply.github.com> Date: Mon, 31 Mar 2025 20:49:11 +0700 Subject: [PATCH 1/5] CI: Upgrade GitHub actions --- .github/workflows/publish.yml | 33 +++++++++++---------- .github/workflows/typescript-smoke-test.yml | 6 ++-- 2 files changed, 20 insertions(+), 19 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 18b077f..cea6fd1 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -11,10 +11,10 @@ env: jobs: check: - runs-on: ubuntu-20.04 + runs-on: ubuntu-24.04 steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Setup Rust uses: dtolnay/rust-toolchain@stable @@ -28,15 +28,15 @@ jobs: run: cargo clippy build: - runs-on: ubuntu-20.04 + runs-on: ubuntu-24.04 steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Setup Node - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: 18.x + node-version: 22.x - name: Setup Rust uses: dtolnay/rust-toolchain@stable @@ -58,9 +58,9 @@ jobs: run: npm run build -- --target x86_64-pc-windows-msvc - name: Upload artifact - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: - name: OS specific binaries + name: binaries-windows-linux path: dist if-no-files-found: error @@ -68,12 +68,12 @@ jobs: runs-on: macos-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Setup Node - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: 18.x + node-version: 22.x - name: Setup Rust uses: dtolnay/rust-toolchain@stable @@ -93,9 +93,9 @@ jobs: run: npm run build -- --target aarch64-apple-darwin - name: Upload artifact - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: - name: OS specific binaries + name: binaries-macos path: dist if-no-files-found: error @@ -107,13 +107,14 @@ jobs: needs: [build, build-mac] steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Download build - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: - name: OS specific binaries path: dist/ + pattern: binaries-* + merge-multiple: true - name: Log files run: | diff --git a/.github/workflows/typescript-smoke-test.yml b/.github/workflows/typescript-smoke-test.yml index 9ab7a09..faecd0d 100644 --- a/.github/workflows/typescript-smoke-test.yml +++ b/.github/workflows/typescript-smoke-test.yml @@ -5,12 +5,12 @@ jobs: test: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Setup Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: 18.x + node-version: 22.x - name: Install NPM dependencies run: npm install && cd test/typescript && npm install From 2b1e5c2dfc77a48c4f8bc3a4cdf4fe382763d681 Mon Sep 17 00:00:00 2001 From: CatLover <152669316+catloversg@users.noreply.github.com> Date: Mon, 28 Apr 2025 10:56:58 +0700 Subject: [PATCH 2/5] Change runner OS version as suggested --- .github/workflows/publish.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index cea6fd1..e0ff51c 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -11,7 +11,7 @@ env: jobs: check: - runs-on: ubuntu-24.04 + runs-on: ubuntu-20.04 steps: - uses: actions/checkout@v4 @@ -28,7 +28,7 @@ jobs: run: cargo clippy build: - runs-on: ubuntu-24.04 + runs-on: ubuntu-20.04 steps: - uses: actions/checkout@v4 From 0ce80fc4f920cb892194939b51ddd6f6657b925d Mon Sep 17 00:00:00 2001 From: CatLover <152669316+catloversg@users.noreply.github.com> Date: Mon, 28 Apr 2025 11:01:04 +0700 Subject: [PATCH 3/5] Revert "Change runner OS version as suggested" This reverts commit 2b1e5c2dfc77a48c4f8bc3a4cdf4fe382763d681. --- .github/workflows/publish.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index e0ff51c..cea6fd1 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -11,7 +11,7 @@ env: jobs: check: - runs-on: ubuntu-20.04 + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v4 @@ -28,7 +28,7 @@ jobs: run: cargo clippy build: - runs-on: ubuntu-20.04 + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v4 From a0025abed56841ab77ffd71f5ce9e4b901489c0b Mon Sep 17 00:00:00 2001 From: CatLover <152669316+catloversg@users.noreply.github.com> Date: Mon, 28 Apr 2025 13:02:41 +0700 Subject: [PATCH 4/5] Use ubuntu-22.04 --- .github/workflows/publish.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index cea6fd1..434a8d4 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -11,7 +11,7 @@ env: jobs: check: - runs-on: ubuntu-24.04 + runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v4 @@ -28,7 +28,7 @@ jobs: run: cargo clippy build: - runs-on: ubuntu-24.04 + runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v4 From f287dfe7d785c5357a7b05c7974532134a007522 Mon Sep 17 00:00:00 2001 From: CatLover <152669316+catloversg@users.noreply.github.com> Date: Mon, 28 Apr 2025 17:09:01 +0700 Subject: [PATCH 5/5] Run in ubuntu:20.04 container --- .github/workflows/publish.yml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 434a8d4..904b770 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -11,7 +11,7 @@ env: jobs: check: - runs-on: ubuntu-22.04 + runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 @@ -28,7 +28,11 @@ jobs: run: cargo clippy build: - runs-on: ubuntu-22.04 + runs-on: ubuntu-latest + + # Run in ubuntu:20.04 container to avoid the issue with glibc version + container: + image: ubuntu:20.04 steps: - uses: actions/checkout@v4 @@ -38,6 +42,9 @@ jobs: with: node-version: 22.x + # ubuntu:20.04 does not have curl and gcc/g++ installed by default + - run: apt-get update && apt-get install -y curl build-essential + - name: Setup Rust uses: dtolnay/rust-toolchain@stable with: