Skip to content

Commit 91b79f3

Browse files
committed
Adjust assessment check
To address sentry issue ECONPLAYGROUND-84
1 parent 7e5c680 commit 91b79f3

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

econplayground/main/tests/test_views.py

+6-2
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,12 @@ def test_get_no_assessment(self):
5959
g.assessment.delete()
6060
g.assessment = None
6161
g.save()
62-
with self.assertRaises(ObjectDoesNotExist):
63-
self.client.get(reverse('graph_detail', kwargs={'pk': g.pk}))
62+
63+
r = self.client.get(reverse('graph_detail', kwargs={'pk': g.pk}))
64+
65+
self.assertEqual(r.status_code, 200)
66+
self.assertContains(r, g.title)
67+
self.assertContains(r, g.topic.cohort.title)
6468

6569

6670
class GraphPickViewTest(LoggedInTestInstructorMixin, TestCase):

econplayground/main/views.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,8 @@ def get_context_data(self, *args, **kwargs):
300300
ctx = super(GraphDetailView, self).get_context_data(*args, **kwargs)
301301

302302
assessment_change_url = None
303-
if self.object.assessment and user_is_instructor(self.request.user):
303+
if hasattr(self.object, 'assessment') and self.object.assessment and \
304+
user_is_instructor(self.request.user):
304305
assessment_change_url = reverse(
305306
'admin:main_assessment_change',
306307
kwargs={'object_id': self.object.assessment.pk})

0 commit comments

Comments
 (0)