Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(home-manager): init wlogout module #398

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

Anomalocaridid
Copy link
Contributor

@Anomalocaridid Anomalocaridid commented Dec 9, 2024

Adds support for wlogout.

Extra options I added:

  • iconStyle, which lets the user specify whether to use the wlogout or wleave-style icons that come with the theme.
  • extraStyle, which lets the user add extra CSS to ~/.config/wlogout.css

In order for the svg icons to display properly, pkgs.librsvg needs to be in programs.gdk-pixbuf.modulePackages, but I am not sure if I should add an assertion or warning or something or not.

@Anomalocaridid Anomalocaridid force-pushed the wlogout branch 4 times, most recently from 98076f2 to d4ea23b Compare December 9, 2024 01:56
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it needs additional packages it maybe worth waiting for #384.

I would also prefer not to merge any PRs adding new modules until #371 is merged too.

@Anomalocaridid
Copy link
Contributor Author

@isabelroses Makes sense. In that case, I will mark this as a draft for now.

@Anomalocaridid Anomalocaridid marked this pull request as draft December 10, 2024 00:02
@Anomalocaridid Anomalocaridid force-pushed the wlogout branch 4 times, most recently from 6736e96 to 9275c88 Compare December 27, 2024 21:38
@Anomalocaridid Anomalocaridid marked this pull request as ready for review December 27, 2024 21:49
@Anomalocaridid
Copy link
Contributor Author

I have updated this PR to reflect the recent treewide changes.

modules/home-manager/wlogout.nix Outdated Show resolved Hide resolved
modules/home-manager/wlogout.nix Outdated Show resolved Hide resolved
@isabelroses isabelroses merged commit 63290ea into catppuccin:main Dec 31, 2024
8 checks passed
@Anomalocaridid Anomalocaridid deleted the wlogout branch December 31, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants