Fix RangedGetMachine skipping keys past min prefix#2110
Merged
Conversation
maxkozlovsky
previously approved these changes
Mar 2, 2026
kkuehlz
force-pushed
the
kkuehler/traverse
branch
from
908fdfe to
19f9713
Compare
Chen-Yifan
previously approved these changes
Mar 2, 2026
kkuehlz
force-pushed
the
kkuehler/traverse
branch
from
19f9713 to
f73d50c
Compare
kkuehlz
force-pushed
the
kkuehler/traverse
branch
from
f73d50c to
c1126e4
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Chen-Yifan
approved these changes
Mar 2, 2026
maxkozlovsky
approved these changes
Mar 2, 2026
does_key_intersect_with_range used starts_with to check short paths against min, which missed paths lexicographically past the min prefix (e.g. path 0x1 with min 0x01234). Compare the path against the truncated min prefix instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kkuehlz
force-pushed
the
kkuehler/traverse
branch
from
c1126e4 to
8502f47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
does_key_intersect_with_range()usedstarts_with()to check short paths against min, which missed paths lexicographically past the min prefix (e.g. path 0x1 with min 0x01234). Compare the path against the truncated min prefix instead.