Skip to content

[When min PyNWB >=v2.1.0]: remove manual fillers for optional ElectrodeTable cols #6

Closed
@CodyCBakerPhD

Description

@CodyCBakerPhD

What would you like to see added to nwb-conversion-tools?

With PyNWB v2.1.0, various electrode columns (x,y,z, location, imp) are no longer required so we could remove those corresponding lines of our write_recording tools using coded defaults to just not propagate them at all if the recording object doesn't have the information set, and let PyNWB handle all the setting automatically.

What we need to decide (likely best at next group meeting) is if we want to enforce the minimal version of the conversion tools to use most recent of PyNWB, et al.

Is your feature request related to a problem?

No response

What solution would you like?

Remove https://github.com/catalystneuro/nwb-conversion-tools/blob/main/src/nwb_conversion_tools/tools/spikeinterface/spikeinterface.py#L368-L380 and dependent lines.

Do you have any interest in helping implement the feature?

Yes.

Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions