Close #143 Increase rendering laziness, 0.8.4

Author: caseywebdev

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.8.4
+- Non-`uniform` type lists with a `window` scroll parent will no longer render
+  an initial page unless they are visible in the viewport. (#143)
+
 ## 0.8.3
 - Use `setTimeout` to detect stack overflow.
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-list",
-  "version": "0.8.3",
+  "version": "0.8.4",
   "author": "Casey Foster <[email protected]>",
   "license": "MIT",
   "main": "react-list.js",

react-list.es6

@@ -75,10 +75,9 @@ module.exports = class ReactList extends Component {
 
   constructor(props) {
     super(props);
-    const {initialIndex, pageSize} = this.props;
+    const {initialIndex} = props;
     const itemsPerRow = 1;
-    const {from, size} =
-      this.constrain(initialIndex, pageSize, itemsPerRow, this.props);
+    const {from, size} = this.constrain(initialIndex, 0, itemsPerRow, props);
     this.state = {from, size, itemsPerRow};
     this.cache = {};
     this.prevPrevState = {};
@@ -392,8 +391,8 @@ module.exports = class ReactList extends Component {
     if (itemSizeEstimator) return itemSizeEstimator(index, cache);
   }
 
-  constrain(from, size, itemsPerRow, {length, pageSize, type}) {
-    size = Math.max(size, pageSize);
+  constrain(from, size, itemsPerRow, {length, type}) {
+    if (type === 'uniform') size = Math.max(size, 1);
     let mod = size % itemsPerRow;
     if (mod) size += itemsPerRow - mod;
     if (size > length) size = length;

react-list.js

@@ -124,13 +124,11 @@
 
       var _this = _possibleConstructorReturn(this, (ReactList.__proto__ || Object.getPrototypeOf(ReactList)).call(this, props));
 
-      var _this$props = _this.props,
-          initialIndex = _this$props.initialIndex,
-          pageSize = _this$props.pageSize;
+      var initialIndex = props.initialIndex;
 
       var itemsPerRow = 1;
 
-      var _this$constrain = _this.constrain(initialIndex, pageSize, itemsPerRow, _this.props),
+      var _this$constrain = _this.constrain(initialIndex, 0, itemsPerRow, props),
           from = _this$constrain.from,
           size = _this$constrain.size;
 
@@ -523,10 +521,9 @@
       key: 'constrain',
       value: function constrain(from, size, itemsPerRow, _ref) {
         var length = _ref.length,
-            pageSize = _ref.pageSize,
             type = _ref.type;
 
-        size = Math.max(size, pageSize);
+        if (type === 'uniform') size = Math.max(size, 1);
         var mod = size % itemsPerRow;
         if (mod) size += itemsPerRow - mod;
         if (size > length) size = length;