Improve portability

[PDLdeLange]

We love the effort but currently we can not use the project due to portability issues. I would propose to make the following changes.

• Introduce "casbin" namespace.
• Remove "using namespace" in all headers.
• Remove "using std" everywhere.

The latter two changes conflict with point 3 of the contribution guide which is actually considered bad practice and decreases portability. See: https://stackoverflow.com/questions/1452721/why-is-using-namespace-std-considered-bad-practice.

Making these changes would make the project more inline with point 12 of the contributation guide and would improve portablity. See also: https://google.github.io/styleguide/cppguide.html#Namespaces.

Happy to help out on this in case this issue is accepted.

[EmperorYP7]

Introduce "casbin" namespace.

I agree. This is really something we should be incorporating here.

Remove "using namespace"/"using std" in all headers

Apart from that, some parts of the directory structure uses snake case which might create unnecessary conflicts with STL. Here's a nice resource where I got to know about this first.

[hsluoyz]

@xcaptain

[bokket]

引入"卡斯宾"命名空间。

我同意。这确实是我们应该在这里纳入的东西。

删除所有标题中的"使用命名空间"/"使用 std"

除此之外，目录结构的某些部分使用蛇壳，这可能会与 STL 产生不必要的冲突。这里有一个很好的资源，在那里我首先了解了这一点。

Amazing! we are following the same YouTube blogger!

[bokket]

We love the effort but currently we can not use the project due to portability issues. I would propose to make the following changes.

• Introduce "casbin" namespace.
• Remove "using namespace" in all headers.
• Remove "using std" everywhere.

The latter two changes conflict with point 3 of the contribution guide which is actually considered bad practice and decreases portability. See: https://stackoverflow.com/questions/1452721/why-is-using-namespace-std-considered-bad-practice.

Making these changes would make the project more inline with point 12 of the contributation guide and would improve portablity. See also: https://google.github.io/styleguide/cppguide.html#Namespaces.

Happy to help out on this in case this issue is accepted.

I think cross-platform testing is the first need, it is very unfriendly to Linuxers like me (wry smiles)

[xcaptain]

Agree, we should close #7 and can simply consider using google's style.

[hsluoyz]

@PDLdeLange I think your opinions sound good. Go ahead!

[PDLdeLange]

Okay!

…

On Wed, Mar 31, 2021, 15:40 hsluoyz ***@***.***> wrote: @PDLdeLange <https://github.com/PDLdeLange> I think your opinions sound good. Go ahead! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#88 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE6CK22AKLMC5MG5IWEE5TTGMQ45ANCNFSM42BR3BCQ> .