Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile type name of library instances with other custom types in the ytt standard lib #579

Open
pivotaljohn opened this issue Jan 10, 2022 · 0 comments
Labels
enhancement This issue is a feature request priority/unprioritized-backlog Higher priority than priority/awaiting-more-evidence but not planned. Contributions are welcome.

Comments

@pivotaljohn
Copy link
Contributor

Describe the problem/challenge you have
Rename type(library.get()) from "module" to "@ytt:library.instance".

For example, with:

_ytt_lib/lib/template.yml
config.yml
#! _ytt_lib/lib/template.yml
---
#! ./config.lib
#@ load("@ytt:library", "library")

type: #@ type(library.get("lib"))

this happens:

ytt -f .
type: module

Describe the solution you'd like

Would rather this output:

ytt -f .
type: @ytt:library.instance

To reconcile the emerging convention of type names in the ytt standard library.

Anything else you would like to add:
Documentation refers to this string already. ;)


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@pivotaljohn pivotaljohn added enhancement This issue is a feature request carvel triage This issue has not yet been triaged for relevance priority/unprioritized-backlog Higher priority than priority/awaiting-more-evidence but not planned. Contributions are welcome. and removed carvel triage This issue has not yet been triaged for relevance labels Jan 10, 2022
@aaronshurley aaronshurley moved this to To Triage in Carvel Aug 18, 2022
@pivotaljohn pivotaljohn moved this from To Triage to Unprioritized in Carvel Sep 27, 2022
@github-project-automation github-project-automation bot moved this to To Triage in Carvel Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue is a feature request priority/unprioritized-backlog Higher priority than priority/awaiting-more-evidence but not planned. Contributions are welcome.
Projects
Status: To Triage
Development

No branches or pull requests

1 participant