Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return an error (rather than panic'ing) when a non-serializable user input is provided for @schema/default #507

Open
pivotaljohn opened this issue Oct 12, 2021 · 0 comments
Labels
enhancement This issue is a feature request priority/unprioritized-backlog Higher priority than priority/awaiting-more-evidence but not planned. Contributions are welcome. snack This issue has been identified as lightweight and potentially quick to deliver.

Comments

@pivotaljohn
Copy link
Contributor

pivotaljohn commented Oct 12, 2021

src: #490

  • today, we generally panic when someone includes a function value (i.e. lambda) in the YAML structure. Ideally, we would error when it’s anticipated bad user input and panic when it is the result of ytt coding error. (example)

repro example:

#@data/values-schema
---
nothing: "something"
#@schema/default lambda: "hellop"
string: ""

ytt -f .

@pivotaljohn pivotaljohn added enhancement This issue is a feature request carvel triage This issue has not yet been triaged for relevance labels Oct 12, 2021
@cari-lynn cari-lynn added priority/unprioritized-backlog Higher priority than priority/awaiting-more-evidence but not planned. Contributions are welcome. and removed carvel triage This issue has not yet been triaged for relevance labels Oct 18, 2021
@cari-lynn cari-lynn added the snack This issue has been identified as lightweight and potentially quick to deliver. label Mar 10, 2022
@aaronshurley aaronshurley moved this to To Triage in Carvel Aug 18, 2022
@pivotaljohn pivotaljohn moved this from To Triage to Unprioritized in Carvel Sep 27, 2022
@github-project-automation github-project-automation bot moved this to To Triage in Carvel Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue is a feature request priority/unprioritized-backlog Higher priority than priority/awaiting-more-evidence but not planned. Contributions are welcome. snack This issue has been identified as lightweight and potentially quick to deliver.
Projects
Status: To Triage
Development

No branches or pull requests

2 participants