-
Notifications
You must be signed in to change notification settings - Fork 48
chore: normalize redirect_url vs redirect_uri param naming #2475
Copy link
Copy link
Open
Description
Problem
The codebase inconsistently uses both redirect_url and redirect_uri as search param names:
controller.ts:752usesredirect_urlsession/provider.ts:296usesredirect_urinode/provider.ts:145usesredirect_urisession.tsxreadsredirect_uriconnection.tswas only readingredirect_url(fixed in fix: check both redirect_url and redirect_uri for domain verification #2474 to check both)
Proposal
Normalize everything to redirect_uri (the OAuth standard name) across the controller SDK and keychain.
Files to update
packages/controller/src/controller.ts— changeredirect_url→redirect_uripackages/controller/src/session/provider.ts:361— changeredirect_url→redirect_uripackages/keychain/src/hooks/connection.ts— removeredirect_urlfallback once controller is updated- Update related tests
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels