Skip to content

Use policy hash comparison instead of deep structural iteration in validatePoliciesSubset #2458

@kronosapiens

Description

@kronosapiens

Context

SessionProvider.validatePoliciesSubset() (in src/session/provider.ts) iterates over every contract/method/message and does deep JSON.stringify comparisons to check whether stored policies are a superset of current policies. This runs on every probe() call to determine if a cached session is still valid.

Suggestion

The WASM layer already computes a merkle root from policies (via toWasmPolicies). Instead of the structural deep comparison, we could compare policy hashes directly — simpler, faster, and less fragile than relying on JSON.stringify ordering for domain/types equality.

The allowedPoliciesRoot field already exists on SessionRegistration but is never used for comparison.

Affected files

  • packages/controller/src/session/provider.ts — browser provider
  • packages/controller/src/node/provider.ts — node provider (same logic ported)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions