fix: modify code to fix lint error

Author: carddev81

provider-middleware/brightspace.go

@@ -7,11 +7,9 @@ import (
 	"fmt"
 	"net/http"
 	"net/url"
-	"os"
 	"strings"
 	"time"
 
-	"github.com/gocarina/gocsv"
 	log "github.com/sirupsen/logrus"
 	"gorm.io/gorm"
 )
@@ -143,7 +141,7 @@ func (srv *BrightspaceService) ImportCourses(db *gorm.DB) error {
 
 	//3. read CSV file and parse organizational units
 	bsCourses := []BrightspaceCourse{}
-	ReadCSV(&bsCourses, csvFile)
+	readCSV(&bsCourses, csvFile)
 	for _, bsCourse := range bsCourses {
 		if bsCourse.IsActive == "TRUE" && bsCourse.IsDeleted == "FALSE" && bsCourse.Type == "Course Offering" {
 			//total progress is going to be on hold for now
@@ -168,17 +166,6 @@ func (srv *BrightspaceService) ImportCourses(db *gorm.DB) error {
 	return nil
 }
 
-func ReadCSV[T any](values *T, csvFilePath string) {
-	coursesFile, err := os.OpenFile(csvFilePath, os.O_RDWR|os.O_CREATE, os.ModePerm)
-	if err != nil {
-		panic(err)
-	}
-	defer coursesFile.Close()
-	if err := gocsv.UnmarshalFile(coursesFile, values); err != nil { // Load clients from file
-		panic(err)
-	}
-}
-
 func (srv *BrightspaceService) ImportMilestones(coursePair map[string]interface{}, mappings []map[string]interface{}, db *gorm.DB, lastRun time.Time) error {
 	fmt.Println("ImportMilestones...")
 	return nil

provider-middleware/brightspace_data.go

@@ -10,9 +10,10 @@ import (
 	"io"
 	"mime/multipart"
 	"net/http"
-	"net/url"
 	"os"
 	"path/filepath"
+
+	"github.com/gocarina/gocsv"
 )
 
 type DataSetPlugin struct {
@@ -82,8 +83,6 @@ func (srv *BrightspaceService) IntoCourse(bsCourse BrightspaceCourse) *models.Co
 			imgPath = ""
 		}
 	}
-
-	externalUrl, err := url.JoinPath(srv.BaseURL, "")
 	course := models.Course{
 		ProviderPlatformID:      srv.ProviderPlatformID,
 		ExternalID:              bsCourse.OrgUnitId,
@@ -93,7 +92,7 @@ func (srv *BrightspaceService) IntoCourse(bsCourse BrightspaceCourse) *models.Co
 		TotalProgressMilestones: uint(0), //come back to this one
 		Description:             "Brightspace Course: " + bsCourse.Name,
 		ThumbnailURL:            imgPath,
-		ExternalURL:             externalUrl,
+		ExternalURL:             srv.BaseURL, //update this when the time comes
 	}
 
 	fmt.Println("image path: ", imgPath)
@@ -222,3 +221,14 @@ func (srv *BrightspaceService) downloadAndUnzipFile(targetDirectory string, targ
 	}
 	return destPath, err
 }
+
+func readCSV[T any](values *T, csvFilePath string) {
+	coursesFile, err := os.OpenFile(csvFilePath, os.O_RDWR|os.O_CREATE, os.ModePerm)
+	if err != nil {
+		panic(err)
+	}
+	defer coursesFile.Close()
+	if err := gocsv.UnmarshalFile(coursesFile, values); err != nil { // Load clients from file
+		panic(err)
+	}
+}