Skip to content

Commit 42984c9

Browse files
committed
Shorten index name on slugs so that it always works. Apply previous changes to cached_slug to db/migrate/ migrations too
1 parent 277784d commit 42984c9

4 files changed

+6
-5
lines changed

base/db/migrate/20100913234706_create_refinerycms_core_schema.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ def self.up
99
t.datetime "created_at"
1010
end
1111

12-
add_index ::Slug.table_name, ["name", "sluggable_type", "scope", "sequence"], :name => "index_#{::Slug.table_name}_on_name_sluggable_type_scope_and_sequence", :unique => true
12+
add_index ::Slug.table_name, ["name", "sluggable_type", "scope", "sequence"], :name => "index_#{::Slug.table_name}_on_n_s_s_and_s", :unique => true
1313
add_index ::Slug.table_name, ["sluggable_id"], :name => "index_#{::Slug.table_name}_on_sluggable_id"
1414
end
1515

db/migrate/20100913234706_create_refinerycms_core_schema.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ def self.up
1010
t.datetime "created_at"
1111
end
1212

13-
add_index ::Slug.table_name, ["name", "sluggable_type", "scope", "sequence"], :name => "index_#{::Slug.table_name}_on_name_sluggable_type_scope_and_sequence", :unique => true
13+
add_index ::Slug.table_name, ["name", "sluggable_type", "scope", "sequence"], :name => "index_#{::Slug.table_name}_on_n_s_s_and_s", :unique => true
1414
add_index ::Slug.table_name, ["sluggable_id"], :name => "index_#{::Slug.table_name}_on_sluggable_id"
1515
end
1616
end

db/migrate/20100913234708_create_refinerycms_pages_schema.rb

-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ def self.up
3636
t.integer "lft"
3737
t.integer "rgt"
3838
t.integer "depth"
39-
t.string "cached_slug"
4039
end
4140

4241
add_index ::Page.table_name, ["depth"], :name => "index_#{::Page.table_name}_on_depth"
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
class RemoveCachedSlugFromPages < ActiveRecord::Migration
22
def self.up
3-
remove_column :pages, :cached_slug
3+
if ::Page.column_names.map(&:to_s).include?('cached_slug')
4+
remove_column ::Page.table_name, :cached_slug
5+
end
46
end
57

68
def self.down
7-
add_column :pages, :cached_slug, :string
9+
# Don't add this column back, it breaks stuff.
810
end
911
end

0 commit comments

Comments
 (0)