From 0f41d197ee125453b64070c9700d6afc59eae8ff Mon Sep 17 00:00:00 2001 From: Pedro Guimaraes Date: Thu, 25 Jan 2024 09:25:21 +0100 Subject: [PATCH 1/3] Add first performance options --- lib/charms/mysql/v0/mysql.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/charms/mysql/v0/mysql.py b/lib/charms/mysql/v0/mysql.py index e0d9f6bb6..df75b6142 100644 --- a/lib/charms/mysql/v0/mysql.py +++ b/lib/charms/mysql/v0/mysql.py @@ -806,6 +806,8 @@ def render_mysqld_configuration( "general_log": "ON", "general_log_file": f"{snap_common}/var/log/mysql/general.log", "slow_query_log_file": f"{snap_common}/var/log/mysql/slowquery.log", + "innodb_flush_method": "O_DIRECT", + "innodb_use_fdatasync": "ON", } if innodb_buffer_pool_chunk_size: From f9075720d24360fd23c8ee922405b412b8ead34e Mon Sep 17 00:00:00 2001 From: phvalguima Date: Thu, 7 Mar 2024 15:40:53 +0100 Subject: [PATCH 2/3] Bump lib version --- lib/charms/mysql/v0/mysql.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/charms/mysql/v0/mysql.py b/lib/charms/mysql/v0/mysql.py index df75b6142..0ae534b66 100644 --- a/lib/charms/mysql/v0/mysql.py +++ b/lib/charms/mysql/v0/mysql.py @@ -117,7 +117,7 @@ def wait_until_mysql_connection(self) -> None: # Increment this PATCH version before using `charmcraft publish-lib` or reset # to 0 if you are raising the major API version -LIBPATCH = 53 +LIBPATCH = 54 UNIT_TEARDOWN_LOCKNAME = "unit-teardown" UNIT_ADD_LOCKNAME = "unit-add" From d9d33de1ef7c6167291ff9a61a64159a5ffc63c2 Mon Sep 17 00:00:00 2001 From: Paulo Machado Date: Thu, 7 Mar 2024 16:22:01 -0300 Subject: [PATCH 3/3] fixed test and libpatch --- lib/charms/mysql/v0/mysql.py | 2 +- tests/unit/test_mysqlsh_helpers.py | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/charms/mysql/v0/mysql.py b/lib/charms/mysql/v0/mysql.py index d16cafd8e..2a4ae7b93 100644 --- a/lib/charms/mysql/v0/mysql.py +++ b/lib/charms/mysql/v0/mysql.py @@ -111,7 +111,7 @@ def wait_until_mysql_connection(self) -> None: # Increment this PATCH version before using `charmcraft publish-lib` or reset # to 0 if you are raising the major API version -LIBPATCH = 55 +LIBPATCH = 56 UNIT_TEARDOWN_LOCKNAME = "unit-teardown" UNIT_ADD_LOCKNAME = "unit-add" diff --git a/tests/unit/test_mysqlsh_helpers.py b/tests/unit/test_mysqlsh_helpers.py index bd19bd60d..38b45e1c0 100644 --- a/tests/unit/test_mysqlsh_helpers.py +++ b/tests/unit/test_mysqlsh_helpers.py @@ -272,6 +272,8 @@ def test_write_mysqld_config( "general_log = ON", "general_log_file = /var/snap/charmed-mysql/common/var/log/mysql/general.log", "slow_query_log_file = /var/snap/charmed-mysql/common/var/log/mysql/slowquery.log", + "innodb_flush_method = O_DIRECT", + "innodb_use_fdatasync = ON", "innodb_buffer_pool_chunk_size = 5678", "\n", ) @@ -312,6 +314,8 @@ def test_write_mysqld_config( "general_log = ON", "general_log_file = /var/snap/charmed-mysql/common/var/log/mysql/general.log", "slow_query_log_file = /var/snap/charmed-mysql/common/var/log/mysql/slowquery.log", + "innodb_flush_method = O_DIRECT", + "innodb_use_fdatasync = ON", "innodb_buffer_pool_chunk_size = 1048576", "performance-schema-instrument = 'memory/%=OFF'", "loose-group_replication_message_cache_size = 134217728",