Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create / Update Profiles based on the PMR #10

Open
kimwnasptd opened this issue Nov 26, 2024 · 1 comment
Open

Create / Update Profiles based on the PMR #10

kimwnasptd opened this issue Nov 26, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@kimwnasptd
Copy link
Contributor

Context

This is a sub-step for completing a common library that handles a PMR #8

In this step, we take for granted that

  1. The create_or_update_profiles(pmr) function is created
  2. It can remove access from stale Profiles

And in this task we want to extend this function to create or update Profiles, based on a PMR. Specifically, if a Profile exists in a PMR but not in the cluster then created it. Similarly if the Profile exists in the PMR, but has a different resourceQuota then the library should update the quota.

Note that we don't want to touch the owner of the Profile, as the namespace will lose the ownership of the namespace https://github.com/kubeflow/kubeflow/issues/6576

What needs to get done

The create_or_update_profiles(pmr) function

  1. Will create a new Profile, if it's defined in PMR but doesn't exist in the cluster
  2. Will update the resourceQuota of a Profile that exists in the cluster, but has different quotas from the one defined in the PMR

Definition of Done

  1. There are integration tests both 2 cases above
  2. The code handling the above cases is merged
@kimwnasptd kimwnasptd added the enhancement New feature or request label Nov 26, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6595.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant