Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROCK will need to use NB_PREFIX env var for Kubeflow integrations #66

Closed
kimwnasptd opened this issue Jan 24, 2024 · 1 comment · Fixed by #72
Closed

ROCK will need to use NB_PREFIX env var for Kubeflow integrations #66

kimwnasptd opened this issue Jan 24, 2024 · 1 comment · Fixed by #72
Assignees

Comments

@kimwnasptd
Copy link

Creating an issue after our findings with @deusebio, for integrating the PySpark ROCK with Kubeflow.

In Kubeflow we deploy jupyter notebooks as a CustomResource, handled by a Charmed Notebooks K8s Controller, which will end up creating STS/Pod for the Notebook requested by the CR.

In Kubeflow all notebooks will be exposed under a different prefix and the servers will need to be aware of this prefix. For this the Charmed Notebooks K8s Controller will end up adding a NB_PREFIX env var, which should be used when launching jupyterlab. Here's an example of how this is used from upstream KF Notebook images:
https://github.com/kubeflow/kubeflow/blob/master/components/example-notebook-servers/jupyter/s6/services.d/jupyterlab/run#L19

Currently this ROCK doesn't take this into account, so the final jupyterlab UI is not accessible to users in Kubeflow, since the server is exposed in a different prefix from the one it's configured to listen to (/)

@deusebio deusebio self-assigned this Feb 7, 2024
@deusebio
Copy link
Contributor

deusebio commented Feb 7, 2024

We have addressed this issue in a recent PR that I have now referenced to the issue

@deusebio deusebio closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants