Skip to content

#each isIterable case not being hit #67

Closed
@phillipskevin

Description

@phillipskevin

@garrettreed commented on Fri Sep 16 2016

The isIterable case within the each helper is not being hit by any of the current tests. That scenario would cause isIterable to be true within this helper?

@justinbmeyer brought this while working on #62. We expected a can.Map to match this case.


@matthewp commented on Fri Sep 30 2016

can-maps are not iterable currently. They would have to implement the iterable API like can-define does here: https://github.com/canjs/can-define/blob/master/can-define.js#L107-L109


@christopherjbaker commented on Fri Mar 31 2017

Solved by canjs/can-define#167, but pending canjs/can-reflect#1


@matthewp commented on Fri Mar 31 2017

@christopherjbaker I think we need the same thing in can-map.


@christopherjbaker commented on Tue Apr 04 2017

Hmm. Adding it the same way to can-map would add a dependency to can-define, which seems counter-productive. I was going to implement it as-is now, but I think its better to wait for can-reflect.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions