feat(coding-agent): add OpenViking memory backend#5254
Conversation
roboomp
left a comment
roboomp
left a comment
There was a problem hiding this comment.
P2 — coherent but large first-class feature spanning 81 files and multiple public/runtime surfaces, so it needs explicit maintainer intent rather than a merge-on-glance recommendation.
No concrete blocking defect found in the reviewed OpenViking protocol, lifecycle, isolation, settings, tool, and TUI paths. bun check passed; focused config, client, protocol, and settings/TUI tests passed. The backend/SDK-focused test files could not start in this checkout because the pre-existing generated src/export/html/tool-views.generated.js asset is absent.
Thanks for the extensive implementation and contract-level coverage, @pppobear.
|
Hi @can1357 when you have a moment, could you please take a look at this PR? It adds the OpenViking memory backend and has passed the focused checks. Given its broader scope, I’d appreciate your guidance on whether the direction and scope are a good fit for the project. Thanks! |
pppobear
force-pushed
the
feat/openviking-memory-backend
branch
from
03c0e5f to
0a3e2a4
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a3e2a42f3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd8f5e4949
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c88fc4f411
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
pppobear
force-pushed
the
feat/openviking-memory-backend
branch
from
c88fc4f to
2b73b43
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b73b43a80
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2 participants
Summary
memory://document accessUnreleasedWhy
OpenViking previously was not available through the coding agent's shared memory contract. This adds the backend while preserving workspace isolation, avoiding duplicated or lost transcript writes across failures and session transitions, and keeping parent/subagent memory state consistent.
Validation
bun checkgit diff --check