Update naming conventions

Author: can-lehmann

buffer.nim

@@ -638,7 +638,7 @@ proc guess_newline_style(text: seq[Rune]): NewlineStyle =
       result = style
       max_score = score
 
-proc make_buffer*(): Buffer =
+proc new_buffer*(): Buffer =
   return Buffer(
     file_path: "",
     text: @[],
@@ -653,7 +653,7 @@ proc make_buffer*(): Buffer =
     newline_style: NewlineLf
   )
 
-proc make_buffer*(path: string, lang: Language = nil): Buffer =
+proc new_buffer*(path: string, lang: Language = nil): Buffer =
   let
     text = to_runes(path.read_file())
     indent_style = text.guess_indent_style()
@@ -677,6 +677,6 @@ proc make_buffer*(path: string, lang: Language = nil): Buffer =
     newline_style: newline_style
   )
 
-proc make_buffer*(path: string, langs: seq[Language]): Buffer =
+proc new_buffer*(path: string, langs: seq[Language]): Buffer =
   let lang = langs.detect_language(path)
-  return make_buffer(path, lang = lang)
+  return new_buffer(path, lang = lang)

calc.nim

@@ -296,10 +296,10 @@ type
     selected: int
     scroll: Index2d
 
-proc make_input(app: App): Input =
+proc init_input(app: App): Input =
   return Input(entry: make_entry(app.copy_buffer), output: nil)
 
-proc make_input(calc: Calc): Input = calc.app.make_input()
+proc init_input(calc: Calc): Input = calc.app.init_input()
 
 proc max_input_number_width(calc: Calc): int =
   ($calc.inputs.len).len + 2
@@ -320,7 +320,7 @@ method process_mouse*(calc: Calc, mouse: Mouse): bool =
 method process_key*(calc: Calc, key: Key) =
   case key.kind:
     of KeyReturn:
-      calc.inputs.insert(calc.make_input(), calc.selected + 1)
+      calc.inputs.insert(calc.init_input(), calc.selected + 1)
       calc.selected += 1
     of KeyArrowDown:
       calc.selected += 1
@@ -373,5 +373,5 @@ method render*(calc: Calc, box: Box, ren: var TermRenderer) =
       ren.move_to(box.min.x + calc.max_input_number_width + 1, box.min.y + it * 3 + 2)
       ren.put($input.output)
 
-proc make_calc*(app: App): Window =
-  return Calc(app: app, inputs: @[app.make_input()])
+proc new_calc*(app: App): Window =
+  return Calc(app: app, inputs: @[app.init_input()])

editor.nim

@@ -588,15 +588,15 @@ proc insert(editor: Editor, str: seq[Rune]) =
 
 proc load_file(editor: Editor, path: string) =
   editor.buffer.unregister_hook(editor.cursor_hook_id)
-  editor.buffer = editor.app.make_buffer(path)
+  editor.buffer = editor.app.new_buffer(path)
   editor.cursor_hook_id = editor.buffer.register_hook(editor.make_cursor_hook())
   editor.hide_prompt()
   editor.cursors = @[Cursor(kind: CursorInsert, pos: 0)]
   editor.autocompleter = editor.app.get_autocompleter(editor.buffer.language)
 
 proc new_buffer(editor: Editor) =
   editor.buffer.unregister_hook(editor.cursor_hook_id)
-  editor.buffer = make_buffer()
+  editor.buffer = new_buffer()
   editor.cursor_hook_id = editor.buffer.register_hook(editor.make_cursor_hook())
   editor.hide_prompt()
   editor.cursors = @[Cursor(kind: CursorInsert, pos: 0)]
@@ -1489,7 +1489,7 @@ method render(editor: Editor, box: Box, ren: var TermRenderer) =
 method close*(editor: Editor) =
   editor.buffer.unregister_hook(editor.cursor_hook_id)  
 
-proc make_editor*(app: App, buffer: Buffer): Editor =
+proc new_editor*(app: App, buffer: Buffer): Editor =
   result = Editor(
     buffer: buffer,
     scroll: Index2d(x: 0, y: 0),
@@ -1499,8 +1499,8 @@ proc make_editor*(app: App, buffer: Buffer): Editor =
   result.cursor_hook_id = result.buffer.register_hook(result.make_cursor_hook())
   result.autocompleter = app.get_autocompleter(result.buffer.language)
 
-proc make_editor*(app: App): Window =
-  make_editor(app, make_buffer())
+proc new_editor*(app: App): Window =
+  new_editor(app, new_buffer())
 
-proc make_editor*(app: App, path: string): Window =
-  make_editor(app, app.make_buffer(path))
+proc new_editor*(app: App, path: string): Window =
+  new_editor(app, app.new_buffer(path))

file_manager.nim

@@ -120,7 +120,7 @@ method process_mouse(file_manager: FileManager, mouse: Mouse): bool =
       case item.kind:
         of ItemDir: file_manager.open(item.path)
         of ItemFile:
-          let editor = file_manager.app.make_editor(item.path)
+          let editor = file_manager.app.new_editor(item.path)
           file_manager.app.root_pane.open_window(editor)
         else: discard
 
@@ -142,7 +142,7 @@ method process_key(file_manager: FileManager, key: Key) =
           file_manager.mode = Mode(kind: ModeNone)
           file_manager.open(item.path)
         of ItemFile:
-          file_manager.app.root_pane.open_window(file_manager.app.make_editor(item.path))
+          file_manager.app.root_pane.open_window(file_manager.app.new_editor(item.path))
         else: discard
     of KeyArrowUp, KeyArrowDown:
       file_manager.list.process_key(key)
@@ -209,7 +209,7 @@ method render(file_manager: FileManager, box: Box, ren: var TermRenderer) =
       ren.move_to(box.min + Index2d(x: sidebar_text.len + 1, y: 1))
       file_manager.mode.search_entry.render(ren)
 
-proc make_file_manager*(app: App): Window =
+proc new_file_manager*(app: App): Window =
   let file_manager = FileManager(app: app)
   file_manager.open(get_current_dir())
   return file_manager

keyinfo.nim

@@ -76,5 +76,5 @@ method list_commands(key_info: KeyInfo): seq[Command] =
     )
   ]
 
-proc make_key_info*(app: App): Window =
+proc new_key_info*(app: App): Window =
   return KeyInfo(app: app, events: @[])

log_viewer.nim

@@ -130,5 +130,5 @@ method render(viewer: Viewer, box: Box, ren: var TermRenderer) =
     y += 1
     it += 1
 
-proc make_log_viewer*(app: App): Window =
+proc new_log_viewer*(app: App): Window =
   Viewer(app: app, attach_end: true)

main.nim

@@ -102,24 +102,24 @@ var
     )
   ]
   window_constructors = @[
-    make_window_constructor("Editor", make_editor),
-    make_window_constructor("File Manager", make_file_manager),
-    make_window_constructor("Calc", make_calc),
-    make_window_constructor("Keyinfo", make_keyinfo),
-    make_window_constructor("Log Viewer", make_log_viewer)
+    init_window_constructor("Editor", new_editor),
+    init_window_constructor("File Manager", new_file_manager),
+    init_window_constructor("Calc", new_calc),
+    init_window_constructor("Keyinfo", new_keyinfo),
+    init_window_constructor("Log Viewer", new_log_viewer)
   ]
 
 var
   app = make_app(languages, window_constructors)
-  root_pane = Pane(kind: PaneWindow, window: app.make_editor())
+  root_pane = Pane(kind: PaneWindow, window: app.new_editor())
 
 if param_count() > 0:
   root_pane = Pane(kind: PaneWindow,
-    window: app.make_editor(param_str(1).absolute_path(get_current_dir()))
+    window: app.new_editor(param_str(1).absolute_path(get_current_dir()))
   )
   for it in 2..param_count():
     var pane = Pane(kind: PaneWindow,
-      window: app.make_editor(param_str(it).absolute_path(get_current_dir()))
+      window: app.new_editor(param_str(it).absolute_path(get_current_dir()))
     )
     root_pane = Pane(kind: PaneSplitH, factor: (it - 1) / it, pane_a: root_pane, pane_b: pane)
 

window_manager.nim

@@ -72,7 +72,7 @@ method close*(window: Window) {.base.} = discard
 method list_commands*(window: Window): seq[Command] {.base.} = discard
 
 # Launcher
-proc make_launcher(app: App): Window =
+proc new_launcher(app: App): Window =
   return Launcher(app: app, list: make_list(app.window_constructors.map(c => c.name)))
 
 proc open_window*(pane: Pane, window: Window)
@@ -113,7 +113,7 @@ method render(launcher: Launcher, box: Box, ren: var TermRenderer) =
 proc make_window*(app: App): Window =
   return app.window_constructors[0].make(app)
 
-proc make_window_constructor*(name: string, make: proc (app: App): Window): WindowConstructor =
+proc init_window_constructor*(name: string, make: proc (app: App): Window): WindowConstructor =
   WindowConstructor(name: name, make: make)
 
 # Command Search
@@ -144,7 +144,7 @@ proc update_list(cmd_search: CommandSearch) =
   if cmd_search.list.selected < 0:
     cmd_search.list.selected = 0
 
-proc make_command_search(app: App, prev_window: Window): Window =
+proc new_command_search(app: App, prev_window: Window): Window =
   let cmd_search = CommandSearch(
     app: app,
     prev_window: prev_window,
@@ -436,10 +436,10 @@ proc render*(pane: Pane, ren: var TermRenderer) =
 
 # App
 proc open_launcher(app: App) =
-  app.root_pane.open_window(app.make_launcher())
+  app.root_pane.open_window(app.new_launcher())
 
 proc open_command_search(app: App) =
-  app.root_pane.open_window(app.make_command_search(app.root_pane.active_window()))
+  app.root_pane.open_window(app.new_command_search(app.root_pane.active_window()))
 
 proc make_app*(languages: seq[Language], window_constructors: seq[WindowConstructor]): owned App =
   for it, lang in languages.pairs:
@@ -465,10 +465,10 @@ proc get_autocompleter*(app: App, language: Language): Autocompleter =
     app.autocompleters[language.id] = autocompleter
   return app.autocompleters[language.id]
 
-proc make_buffer*(app: App, path: string): Buffer =
+proc new_buffer*(app: App, path: string): Buffer =
   if app.buffers.has_key(path):
     return app.buffers[path]
-  result = make_buffer(path, app.languages)
+  result = new_buffer(path, app.languages)
   app.buffers[path] = result
 
   let comp = app.get_autocompleter(result.language)