Cleanup

Author: kraenhansen

packages/ferric/src/build.ts

@@ -26,7 +26,6 @@ import {
   ensureInstalledTargets,
   filterTargetsByPlatform,
 } from "./targets.js";
-import { error } from "node:console";
 
 const ANDROID_TRIPLET_PER_TARGET: Record<AndroidTargetName, AndroidTriplet> = {
   "aarch64-linux-android": "aarch64-linux-android",
@@ -90,7 +89,7 @@ export const buildCommand = new Command("build")
         }
         ensureCargo();
         ensureInstalledTargets(targets);
-        // TODO: Ensure the iOS and Android targets are installed
+
         const appleTargets = filterTargetsByPlatform(targets, "apple");
         const androidTargets = filterTargetsByPlatform(targets, "android");
 
@@ -192,8 +191,6 @@ export const buildCommand = new Command("build")
             }
           );
         }
-
-        // TODO: Handle Apple and constructing an XCFramework
       } catch (error) {
         if (error instanceof SpawnFailure) {
           error.flushOutput("both");

packages/ferric/src/targets.ts

@@ -51,6 +51,10 @@ export type AppleTargetName = (typeof APPLE_TARGETS)[number];
 export const ALL_TARGETS = [...ANDROID_TARGETS, ...APPLE_TARGETS] as const;
 export type TargetName = (typeof ALL_TARGETS)[number];
 
+/**
+ * Ensure the targets are installed into the Rust toolchain
+ * We do this up-front because the error message and fix is very unclear from the failure when missing.
+ */
 export function ensureInstalledTargets(expectedTargets: Set<TargetName>) {
   const installedTargets = getInstalledTargets();
   const missingTargets = new Set([