Recharts vitest #423
Draft
Recharts vitest #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ckifer
reviewed
Nov 1, 2023
| @@ -40,10 +43,17 @@ export async function run(options: MeasureOptions) { | |||
| const header = { metadata }; | |||
| writeFileSync(outputFile, JSON.stringify(header) + '\n'); | |||
|
|
|||
| const testRunnerPath = process.env.TEST_RUNNER_PATH ?? getJestBinPath(); | |||
| if (!RUNNERS.includes(options.runner)) { | |||
| logger.error(`❌ Invalid runner provided: ${options.runner}. Valid options are 'jest' and 'vitest'`); | |||
There was a problem hiding this comment.
nit: could enumerate the options from your RUNNERS const. The native node test runner could be added later for example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows for users to pass in
--runnerflag to use eitherjestorvitestfor the test runner. Defaults to `jest if no value is provided.Issue link
Test plan