Skip to content

Move react-native-gesture-handler to peerDependencies #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
douglasjunior opened this issue Mar 5, 2025 · 3 comments
Closed

Move react-native-gesture-handler to peerDependencies #1753

douglasjunior opened this issue Mar 5, 2025 · 3 comments

Comments

@douglasjunior
Copy link

Describe the bug

Today the react-native-gesture-handler is on "dependencies" section:

"dependencies": {
"chalk": "^4.1.2",
"jest-matcher-utils": "^29.7.0",
"pretty-format": "^29.7.0",
"react-native-gesture-handler": "^2.23.1",
"redent": "^3.0.0"
},

This causes conflict with react-native-gesture-handler version installed on project:

Image

Expected behavior

Move react-native-gesture-handler to peerDependencies or devDependencies

Steps to Reproduce

Just create a new Expo project and then install @testing-library/react-native

Screenshots

N/A

Versions

@testing-library/react-native: 13.1.0 => 13.1.0 
react: 18.3.1 => 18.3.1 
react-native: 0.76.7 => 0.76.7 
react-test-renderer: 18.3.1 => 18.3.1 
@douglasjunior
Copy link
Author

I'd appreciate feedback on this. If it's acceptable, I can proceed with creating a PR to address the issue.

@mdjastrzebski
Copy link
Member

my bad, should be dev-deps. Fixing now.

@mdjastrzebski
Copy link
Member

Moved to dev-deps, not a peer dep realy. Fixed in #1754. Released as 13.1.1! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants