Skip to content

Commit

Permalink
fix: user event add target prop (#1538)
Browse files Browse the repository at this point in the history 
* fix: add empty target and current target event props

* chore: update snapshot tests

* refactor: move noisy snapshot to separate files
  • Loading branch information
@mdjastrzebski
mdjastrzebski authored Nov 30, 2023
1 parent 7acec0c commit 45037f6
Show file tree
Hide file tree
Showing 13 changed files with 429 additions and 180 deletions.
48 changes: 48 additions & 0 deletions src/user-event/__tests__/__snapshots__/clear.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,38 +5,46 @@ exports[`clear() supports basic case: value: "Hello! 1`] = `
{
"name": "focus",
"payload": {
"currentTarget": {},
"nativeEvent": {
"target": 0,
},
"target": {},
},
},
{
"name": "selectionChange",
"payload": {
"currentTarget": {},
"nativeEvent": {
"selection": {
"end": 6,
"start": 0,
},
},
"target": {},
},
},
{
"name": "keyPress",
"payload": {
"currentTarget": {},
"nativeEvent": {
"key": "Backspace",
},
"target": {},
},
},
{
"name": "change",
"payload": {
"currentTarget": {},
"nativeEvent": {
"eventCount": 0,
"target": 0,
"text": "",
},
"target": {},
},
},
{
Expand All @@ -46,29 +54,35 @@ exports[`clear() supports basic case: value: "Hello! 1`] = `
{
"name": "selectionChange",
"payload": {
"currentTarget": {},
"nativeEvent": {
"selection": {
"end": 0,
"start": 0,
},
},
"target": {},
},
},
{
"name": "endEditing",
"payload": {
"currentTarget": {},
"nativeEvent": {
"target": 0,
"text": "",
},
"target": {},
},
},
{
"name": "blur",
"payload": {
"currentTarget": {},
"nativeEvent": {
"target": 0,
},
"target": {},
},
},
]
Expand All @@ -79,38 +93,46 @@ exports[`clear() supports defaultValue prop: defaultValue: "Hello Default!" 1`]
{
"name": "focus",
"payload": {
"currentTarget": {},
"nativeEvent": {
"target": 0,
},
"target": {},
},
},
{
"name": "selectionChange",
"payload": {
"currentTarget": {},
"nativeEvent": {
"selection": {
"end": 14,
"start": 0,
},
},
"target": {},
},
},
{
"name": "keyPress",
"payload": {
"currentTarget": {},
"nativeEvent": {
"key": "Backspace",
},
"target": {},
},
},
{
"name": "change",
"payload": {
"currentTarget": {},
"nativeEvent": {
"eventCount": 0,
"target": 0,
"text": "",
},
"target": {},
},
},
{
Expand All @@ -120,29 +142,35 @@ exports[`clear() supports defaultValue prop: defaultValue: "Hello Default!" 1`]
{
"name": "selectionChange",
"payload": {
"currentTarget": {},
"nativeEvent": {
"selection": {
"end": 0,
"start": 0,
},
},
"target": {},
},
},
{
"name": "endEditing",
"payload": {
"currentTarget": {},
"nativeEvent": {
"target": 0,
"text": "",
},
"target": {},
},
},
{
"name": "blur",
"payload": {
"currentTarget": {},
"nativeEvent": {
"target": 0,
},
"target": {},
},
},
]
Expand All @@ -154,33 +182,40 @@ How are you?" multiline: true, 1`] = `
{
"name": "focus",
"payload": {
"currentTarget": {},
"nativeEvent": {
"target": 0,
},
"target": {},
},
},
{
"name": "selectionChange",
"payload": {
"currentTarget": {},
"nativeEvent": {
"selection": {
"end": 25,
"start": 0,
},
},
"target": {},
},
},
{
"name": "keyPress",
"payload": {
"currentTarget": {},
"nativeEvent": {
"key": "Backspace",
},
"target": {},
},
},
{
"name": "textInput",
"payload": {
"currentTarget": {},
"nativeEvent": {
"previousText": "Hello World!
How are you?",
Expand All @@ -191,16 +226,19 @@ How are you?",
"target": 0,
"text": "",
},
"target": {},
},
},
{
"name": "change",
"payload": {
"currentTarget": {},
"nativeEvent": {
"eventCount": 0,
"target": 0,
"text": "",
},
"target": {},
},
},
{
Expand All @@ -210,41 +248,49 @@ How are you?",
{
"name": "selectionChange",
"payload": {
"currentTarget": {},
"nativeEvent": {
"selection": {
"end": 0,
"start": 0,
},
},
"target": {},
},
},
{
"name": "contentSizeChange",
"payload": {
"currentTarget": {},
"nativeEvent": {
"contentSize": {
"height": 16,
"width": 0,
},
"target": 0,
},
"target": {},
},
},
{
"name": "endEditing",
"payload": {
"currentTarget": {},
"nativeEvent": {
"target": 0,
"text": "",
},
"target": {},
},
},
{
"name": "blur",
"payload": {
"currentTarget": {},
"nativeEvent": {
"target": 0,
},
"target": {},
},
},
]
Expand All @@ -259,10 +305,12 @@ exports[`clear() works when not all events have handlers 1`] = `
{
"name": "endEditing",
"payload": {
"currentTarget": {},
"nativeEvent": {
"target": 0,
"text": "",
},
"target": {},
},
},
]
Expand Down
9 changes: 7 additions & 2 deletions src/user-event/event-builder/common.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
*/
function touch() {
return {
persist: jest.fn(),
currentTarget: { measure: jest.fn() },
nativeEvent: {
changedTouches: [],
identifier: 0,
Expand All @@ -18,6 +16,9 @@ function touch() {
timestamp: Date.now(),
touches: [],
},
persist: jest.fn(),
currentTarget: { measure: jest.fn() },
target: {},
};
}

Expand Down Expand Up @@ -48,6 +49,8 @@ export const CommonEventBuilder = {
nativeEvent: {
target: 0,
},
currentTarget: {},
target: {},
};
},

Expand All @@ -61,6 +64,8 @@ export const CommonEventBuilder = {
nativeEvent: {
target: 0,
},
currentTarget: {},
target: {},
};
},
};
2 changes: 2 additions & 0 deletions src/user-event/event-builder/scroll-view.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ export const ScrollViewEventBuilder = {
target: 0,
velocity: { y: 0, x: 0 },
},
currentTarget: {},
target: {},
};
},
};
14 changes: 14 additions & 0 deletions src/user-event/event-builder/text-input.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ export const TextInputEventBuilder = {
change: (text: string) => {
return {
nativeEvent: { text, target: 0, eventCount: 0 },
currentTarget: {},
target: {},
};
},

Expand All @@ -21,6 +23,8 @@ export const TextInputEventBuilder = {
keyPress: (key: string) => {
return {
nativeEvent: { key },
currentTarget: {},
target: {},
};
},

Expand All @@ -32,6 +36,8 @@ export const TextInputEventBuilder = {
submitEditing: (text: string) => {
return {
nativeEvent: { text, target: 0 },
currentTarget: {},
target: {},
};
},

Expand All @@ -43,6 +49,8 @@ export const TextInputEventBuilder = {
endEditing: (text: string) => {
return {
nativeEvent: { text, target: 0 },
currentTarget: {},
target: {},
};
},

Expand All @@ -54,6 +62,8 @@ export const TextInputEventBuilder = {
selectionChange: ({ start, end }: TextRange) => {
return {
nativeEvent: { selection: { start, end } },
currentTarget: {},
target: {},
};
},

Expand All @@ -70,6 +80,8 @@ export const TextInputEventBuilder = {
range: { start: text.length, end: text.length },
target: 0,
},
currentTarget: {},
target: {},
};
},

Expand All @@ -81,6 +93,8 @@ export const TextInputEventBuilder = {
contentSizeChange: ({ width, height }: ContentSize) => {
return {
nativeEvent: { contentSize: { width, height }, target: 0 },
currentTarget: {},
target: {},
};
},
};
Loading

0 comments on commit 45037f6

Please sign in to comment.