Skip to content

Commit ece95c3

Browse files
draggievonovak
andauthored
fix: new arch android interface (#654)
* fix: new arch android interface * fix: height on android * revert: fix android * Update package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java Co-authored-by: Vojtech Novak <[email protected]> * Update package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java Co-authored-by: Vojtech Novak <[email protected]> * Update package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java Co-authored-by: Vojtech Novak <[email protected]> --------- Co-authored-by: Vojtech Novak <[email protected]>
1 parent b528795 commit ece95c3

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

example/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"babel-preset-expo": "^9.2.0",
2020
"react": "18.2.0",
2121
"react-native": "0.73.5",
22-
"react-native-pager-view": "^6.2.3",
22+
"react-native-pager-view": "^6.4.1",
2323
"react-native-windows": "0.73.11"
2424
},
2525
"devDependencies": {

package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -125,12 +125,12 @@ public void setValue(ReactSlider view, float value) {
125125
ReactSliderManagerImpl.setValue(view, value);
126126
}
127127

128-
@ReactProp(name = "minimumValue", defaultFloat = 0f)
128+
@ReactProp(name = "minimumValue", defaultDouble = 0d)
129129
public void setMinimumValue(ReactSlider view, double value) {
130130
ReactSliderManagerImpl.setMinimumValue(view, value);
131131
}
132132

133-
@ReactProp(name = "maximumValue", defaultFloat = 1f)
133+
@ReactProp(name = "maximumValue", defaultDouble = 1d)
134134
public void setMaximumValue(ReactSlider view, double value) {
135135
ReactSliderManagerImpl.setMaximumValue(view, value);
136136
}
@@ -145,8 +145,8 @@ public void setUpperLimit(ReactSlider view, float value) {
145145
ReactSliderManagerImpl.setUpperLimit(view, value);
146146
}
147147

148-
@ReactProp(name = "step", defaultFloat = 0f)
149-
public void setStep(ReactSlider view, float value) {
148+
@ReactProp(name = "step", defaultDouble = 0d)
149+
public void setStep(ReactSlider view, double value) {
150150
ReactSliderManagerImpl.setStep(view, value);
151151
}
152152

package/src/RNCSliderNativeComponent.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import type {
77
WithDefault,
88
DirectEventHandler,
99
BubblingEventHandler,
10+
Double,
1011
} from 'react-native/Libraries/Types/CodegenTypes';
1112

1213
type Event = Readonly<{
@@ -23,15 +24,15 @@ export interface NativeProps extends ViewProps {
2324
tapToSeek?: WithDefault<boolean, false>;
2425
maximumTrackImage?: ImageSource;
2526
maximumTrackTintColor?: ColorValue;
26-
maximumValue?: Float;
27+
maximumValue?: Double;
2728
minimumTrackImage?: ImageSource;
2829
minimumTrackTintColor?: ColorValue;
29-
minimumValue?: Float;
30+
minimumValue?: Double;
3031
onChange?: BubblingEventHandler<Event>;
3132
onRNCSliderSlidingStart?: DirectEventHandler<Event>;
3233
onRNCSliderSlidingComplete?: DirectEventHandler<Event>;
3334
onRNCSliderValueChange?: BubblingEventHandler<Event>;
34-
step?: Float;
35+
step?: Double;
3536
testID?: string;
3637
thumbImage?: ImageSource;
3738
thumbTintColor?: ColorValue;

0 commit comments

Comments
 (0)